Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument non-index Elasticsearch client methods #435

Closed
adamchainz opened this issue Jan 2, 2020 · 0 comments · Fixed by #438
Closed

Instrument non-index Elasticsearch client methods #435

adamchainz opened this issue Jan 2, 2020 · 0 comments · Fixed by #438

Comments

@adamchainz
Copy link
Contributor

adamchainz commented Jan 2, 2020 •
edited
Loading

There are many methods on the elasticsearch-py client class that we aren't instrumenting, for example ping(), because they don't operate on an index.

We should capture all these calls too - I'm sure many applications have such calls that would be good to show on traces.

https://github.com/elastic/elasticsearch-py/blob/master/elasticsearch/client/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tracking for missing Elasticsearch client methods scoutapp/scout_apm_python
1 participant
@adamchainz