Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary include of entity framework in nuget package #26

Closed
antidemon opened this issue Sep 16, 2015 · 2 comments
Closed

Unnecessary include of entity framework in nuget package #26

antidemon opened this issue Sep 16, 2015 · 2 comments

Comments

@antidemon
Copy link

As far as I can see from the source download from http://www.albahari.com/nutshell/LinqKitSource.zip there is no need for the nuget package to include entity framework apart from for the demo project. Can we remove this dependency from the nuget package please.

@Thorium
Copy link
Collaborator

Thorium commented Sep 29, 2015

Source code on www.albahari.com is quite old. Since then we had to support async queries. And for that we need the interfaces from EF:
IDbAsyncEnumerator<T> and IDbAsyncEnumerable<T>

So after this commit there has been this dependency:
890bccc

The old .NET 3.5 version actually wouldn't need EF, so this is removed from the LinqKit.Net35 solution. #18

Is that ok..?

@Thorium
Copy link
Collaborator

Thorium commented Oct 2, 2015

Now you can get also the 3.5 version from the NuGet package, from version LinqKit 1.1.3

@Thorium Thorium closed this as completed Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants