Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing ABC directly from collections module was removed in Python 3.9 #196

Closed
tirkarthi opened this issue Jan 22, 2020 · 3 comments
Closed

Importing ABC directly from collections module was removed in Python 3.9 #196

tirkarthi opened this issue Jan 22, 2020 · 3 comments
Assignees
@scott-griffiths
Milestone
3.1.7

Comments

@tirkarthi
Copy link

https://bugzilla.redhat.com/show_bug.cgi?id=1792933

bitstring/bitstring.py

Line 1314 in e886c88

if isinstance(s, collections.Iterable):

bitstring/test/test_bitstream.py

Line 3460 in e886c88

self.assertTrue(isinstance(range(10), collections.Iterable))

Thanks for the library!
@scott-griffiths scott-griffiths self-assigned this Jan 22, 2020
@scott-griffiths scott-griffiths added this to the 3.1.7 milestone Jan 22, 2020
@scott-griffiths
Copy link
Owner

Thanks for letting me know. I should be able to add a fix in the next point release.

@tirkarthi
Copy link
Author

You're welcome. If you haven't started work on this, I can raise a PR for this.

@tirkarthi tirkarthi mentioned this issue Jan 22, 2020
Closed
@scott-griffiths
Copy link
Owner

Fixed in 3.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scott-griffiths scott-griffiths

Labels
None yet
Projects
None yet
Milestone
3.1.7
2 participants
@tirkarthi @scott-griffiths