feat: add WaveComponent #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 498 498
=========================================
Hits 498 498
Continue to review full report at Codecov.
|
mehdicherf
reviewed
Dec 10, 2021
src/service/waveHandler.js
Outdated
| return acc | ||
| }, WAVE_SUBTYPE) | ||
| } | ||
| console.log(this.type) |
There was a problem hiding this comment.
question: Is this a remaining of a debugging session or is it useful to always have this log?
There was a problem hiding this comment.
That is something I forgot to clean after the debugging session, nice catch !
Thanks
|
Code Climate has analyzed commit 1cb518d and detected 0 issues on this pull request. View more on Code Climate. |
7 tasks
mehdicherf
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains
New types for all API version:
Explain your changes
Add new entry in metadata file
Add new folder for discovery
Adapt the WaveHandler to support multiple folder
Does this close any currently open issues?
closes #218
Any particular element to being able to test locally
Run jest
yarn testAny other comments?
Where has this been tested?
Operating System: root:xnu-6153.141.43~1/RELEASE_X86_64
yarn version: 1.22.17
node version: v14.18.1
git version: 2.34.1
sfdx version: sfdx-cli/7.129.0 darwin-x64 node-v14.18.1
sgd plugin version: 4.11.0