Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api version 51 #137

Merged
merged 4 commits into from
Apr 27, 2021
Merged

feat: add api version 51 #137

merged 4 commits into from
Apr 27, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Add API version 51 metadata file support
Add a script to upgrade API version metadata
Add an attribute in the package.json to store the latest current API
Bind this attribute in the code for API default value usage

Any particular element to being able to test locally


Use the new script in the package.json.
It requires jq and sponge installed

$ yarn increment:apiversion

It will increment the attribute sfdc.latestApiVersion in the package.json
And create a new file in src/metadata for the new API version
It works in unix like environment

Any other comments?


If you need to do something twice, then you should automate it instead of doing it
-- Smart Lazy guy

Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Tue Jan 12 22:04:47 PST 2021; root:xnu-4903.278.56~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v14.16.0

git version: git version 2.31.1

sfdx version: sfdx-cli/7.98.0 darwin-x64 node-v14.16.0

sgd plugin version: sfdx-git-delta 4.4.0

@scolladon scolladon requested a review from mehdicherf April 26, 2021 18:17
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #137 (23bffb0) into master (fea248c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          18       18           
  Lines         402      402           
=======================================
  Hits          399      399           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea248c...23bffb0. Read the comment docs.

mehdicherf
mehdicherf previously approved these changes Apr 27, 2021
@codeclimate
Copy link

codeclimate bot commented Apr 27, 2021

Code Climate has analyzed commit 23bffb0 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 1d4fc25 into master Apr 27, 2021
@scolladon scolladon deleted the feature/new-api-versions branch April 27, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants