Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate adding atleast_1d method to tensorlib #974

Open
matthewfeickert opened this issue Jul 21, 2020 · 2 comments
Open

Investigate adding atleast_1d method to tensorlib #974

matthewfeickert opened this issue Jul 21, 2020 · 2 comments
Assignees
@matthewfeickert
Labels
API Changes the public API feat/enhancement New feature or request follow up

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Jul 21, 2020 •
edited
Loading

Description

As @lukasheinrich mentioned in PR #972, it could be nice at times to have a atleast_1d method in the tensorlib.

This already exists in NumPy and JAX

and it looks like it will be added to PyTorch in the future as it exists on master

similarly TensorFlow is only available in the nightly build

Related Issue

Issue #973
@matthewfeickert matthewfeickert added feat/enhancement New feature or request follow up API Changes the public API labels Jul 21, 2020
@matthewfeickert matthewfeickert self-assigned this Jul 28, 2020
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Jul 28, 2020 •
edited
Loading

@kratsg @lukasheinrich If there is still interest in this I have a branch (feat/add-atleast_1d-method) with this already implemented. I think this would have limited use, but it could still have some use.

@kratsg
Copy link
Contributor

kratsg commented Jul 28, 2020

Is the need only to handle the "return scalars"? Does a user need access to this publicly?

@matthewfeickert matthewfeickert mentioned this issue Aug 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewfeickert matthewfeickert

Labels
API Changes the public API feat/enhancement New feature or request follow up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratsg @matthewfeickert