Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background-only workspaces cannot be built as models #514

Closed
3 tasks done
kratsg opened this issue Jul 17, 2019 · 1 comment · Fixed by #950
Closed
3 tasks done

background-only workspaces cannot be built as models #514

kratsg opened this issue Jul 17, 2019 · 1 comment · Fixed by #950
Assignees
Labels
bug Something isn't working docs Documentation related feat/enhancement New feature or request schema and spec JSON schema

Comments

@kratsg
Copy link
Contributor

kratsg commented Jul 17, 2019

Description

If we specify a background-only workspace, this passes the workspace.json schema, but we cannot build a Model from it, but we can build a Workspace from it.

Expected Behavior

We expect to be able to build a (background-only?) Model.

Actual Behavior

An error message like

pyhf.exceptions.InvalidModel: The parameter of interest 'mu_SIG' cannot be fit as it is not declared in the model specification.

Steps to Reproduce

Using the background-only JSON from the sbottom analysis causes this. Then running

import pyhf, json
w = pyhf.Workspace(json.load(file('BkgOnly.json')))
w.model()

Checklist

  • Run git fetch to get the most up to date version of master
  • Searched through existing Issues to confirm this is not a duplicate issue
  • Filled out the Description, Expected Behavior, Actual Behavior, and Steps to Reproduce sections above or have edited/removed them in a way that fully describes the issue
@kratsg kratsg added bug Something isn't working docs Documentation related feat/enhancement New feature or request schema and spec JSON schema labels Jul 17, 2019
@kratsg
Copy link
Contributor Author

kratsg commented Sep 17, 2019

Idea: provide a background-only which (a background-only workspace still has to have a measurement object) which switches to using the lumi as the POI. The other idea is to fix the BkgOnly.json such that the POI is lumi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related feat/enhancement New feature or request schema and spec JSON schema
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants