We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iminuit/cmake.py
Line 40 in 2b47d07
This could throw and is currently unprotected. See https://docs.python.org/3.5/library/multiprocessing.html#multiprocessing.cpu_count . Instead, maybe use os.cpu_count(), new in 3.4+: https://docs.python.org/3.5/library/os.html#os.cpu_count which returns None instead if undeterminable.
os.cpu_count()
Suggestion:
njobs = self.parallel or multiprocessing.cpu_count() or 1
The text was updated successfully, but these errors were encountered:
Thank you that is a good suggestion, will do.
Sorry, something went wrong.
Looks good! Have I mentioned I love Python 3? :)
Yes, it is great, and now that we don't have to support 3.5 anymore, I can also use f-strings in libraries...
I am curious to see pyupgrade on iMinuit, see scikit-hep/pyhf#1164.
Good, 3.6+ is great. :)
No branches or pull requests
iminuit/cmake.py
Line 40 in 2b47d07
This could throw and is currently unprotected. See https://docs.python.org/3.5/library/multiprocessing.html#multiprocessing.cpu_count . Instead, maybe use
os.cpu_count()
, new in 3.4+: https://docs.python.org/3.5/library/os.html#os.cpu_count which returns None instead if undeterminable.Suggestion:
The text was updated successfully, but these errors were encountered: