Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ReadOnly annotation incompatible with PHP 8.1 #1331

Closed
mbabker opened this issue Jul 25, 2021 · 1 comment · Fixed by #1333
Closed

@ReadOnly annotation incompatible with PHP 8.1 #1331

mbabker opened this issue Jul 25, 2021 · 1 comment · Fixed by #1333

Comments

@mbabker
Copy link
Contributor

mbabker commented Jul 25, 2021

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

The readonly properties RFC makes readonly a keyword in PHP 8.1. This results in ParseError: syntax error, unexpected token "readonly" errors when parsing annotations thanks to the JMS\Serializer\Annotation\ReadOnly class.
@goetas
Copy link
Collaborator

goetas commented Jul 26, 2021

:(

the only suggestion I have is to rename it into "ReadOnlyProperty"...

@mbabker mbabker mentioned this issue Jul 31, 2021
Merged
@goetas goetas linked a pull request Aug 1, 2021 that will close this issue
Deprecate @ReadOnly annotation in favor of @ReadOnlyProperty #1333
Merged
@goetas goetas closed this as completed Aug 1, 2021
This was referenced Feb 16, 2022
Closed
Closed
@dilowagner dilowagner mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate @ReadOnly annotation in favor of @ReadOnlyProperty
2 participants
@mbabker @goetas