Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

feat: new SubmitErrorAlert #82

Merged
merged 4 commits into from
Feb 10, 2022
Merged

feat: new SubmitErrorAlert #82

merged 4 commits into from
Feb 10, 2022

Conversation

chambo-e
Copy link
Contributor

Summary

Was named FormErrorAlert

Type

  • Feature

@chambo-e chambo-e requested review from philibea and QuiiBz February 10, 2022 11:28
@chambo-e chambo-e self-assigned this Feb 10, 2022
@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 11:28 Inactive
@chambo-e chambo-e changed the base branch from main to fix/form_errors February 10, 2022 11:35
@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 11:35 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #82 (1b125ed) into main (b2da96e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        18    +1     
  Lines          142       146    +4     
  Branches        14        15    +1     
=========================================
+ Hits           142       146    +4     
Impacted Files Coverage Δ
src/components/SubmitErrorAlert/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2da96e...1b125ed. Read the comment docs.

@chambo-e chambo-e force-pushed the feat/submitErrorAlert branch from 32c6b5b to 001e9e3 Compare February 10, 2022 11:46
@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 11:46 Inactive
@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 15:15 Inactive
@vincentaudebert
Copy link
Contributor

Screenshot 2022-02-10 at 16 24 36

Should we add some margin just for beauty purpose?

@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 15:37 Inactive
@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 15:42 Inactive
Base automatically changed from fix/form_errors to main February 10, 2022 15:44
@chambo-e chambo-e force-pushed the feat/submitErrorAlert branch from 57a68de to 1b125ed Compare February 10, 2022 15:46
@github-actions github-actions bot temporarily deployed to feat-submiterroralert February 10, 2022 15:46 Inactive
@chambo-e chambo-e merged commit de535a4 into main Feb 10, 2022
@chambo-e chambo-e deleted the feat/submitErrorAlert branch February 10, 2022 15:54
scaleway-bot pushed a commit that referenced this pull request Feb 10, 2022
## [1.11.0](v1.10.0...v1.11.0) (2022-02-10)

### ⚙️ Features

* new SubmitErrorAlert ([#82](#82)) ([de535a4](de535a4))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants