Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

feat: allow Submit customization and fix form error cascade #81

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

chambo-e
Copy link
Contributor

Summary

Type

  • Feature

@chambo-e chambo-e self-assigned this Feb 10, 2022
@github-actions github-actions bot temporarily deployed to fix-form-errors February 10, 2022 11:27 Inactive
@github-actions github-actions bot temporarily deployed to fix-form-errors February 10, 2022 11:35 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #81 (c4ceaa7) into main (4c7bbb4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          140       142    +2     
  Branches        13        14    +1     
=========================================
+ Hits           140       142    +2     
Impacted Files Coverage Δ
src/components/Form/index.tsx 100.00% <100.00%> (ø)
src/components/Submit/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4444330...c4ceaa7. Read the comment docs.

@chambo-e chambo-e requested a review from philibea February 10, 2022 11:37
@github-actions github-actions bot temporarily deployed to fix-form-errors February 10, 2022 11:46 Inactive
@vincentaudebert
Copy link
Contributor

Wondering about showing in stories the new disabled / variant cases?

@vincentaudebert vincentaudebert self-requested a review February 10, 2022 15:29
@chambo-e chambo-e merged commit b2da96e into main Feb 10, 2022
@chambo-e chambo-e deleted the fix/form_errors branch February 10, 2022 15:44
scaleway-bot pushed a commit that referenced this pull request Feb 10, 2022
## [1.10.0](v1.9.2...v1.10.0) (2022-02-10)

### ⚙️ Features

* allow Submit customization and fix form error cascade ([#81](#81)) ([b2da96e](b2da96e))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants