This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
fix: skipping initial button state #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptisteArno
requested review from
a team,
vincentaudebert and
QuiiBz
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
+ Coverage 91.78% 91.83% +0.05%
==========================================
Files 25 25
Lines 292 294 +2
Branches 36 36
==========================================
+ Hits 268 270 +2
Misses 13 13
Partials 11 11
Continue to review full report at Codecov.
|
baptisteArno
force-pushed
the
fix/loading-for-button-only-forms
branch
from
80bcc2a to
a36c937
Compare
matthprost
approved these changes
Aug 31, 2022
QuiiBz
approved these changes
Aug 31, 2022
scaleway-bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
## [1.25.6](v1.25.5...v1.25.6) (2022-08-31) ### 📦 Chore * **devdeps:** update jest monorepo to v29 ([#460](#460)) ([a803710](a803710)) ### ⚡ Refactor * **Toggle:** switch to toggle ([#465](#465)) ([9c2a6b0](9c2a6b0)) ### 🐛 Bug Fixes * skipping initial button state ([#380](#380)) ([db21691](db21691))
|
🎉 This PR is included in version 1.25.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relying on the
touchedproperty for skipping the initial button state didn't work with forms that contain only a button.This PR is another proposition to "skip" the initial button state. And it fixes the single-button form.
It is solving the following button flashing issue:
CleanShot.2022-07-08.at.18.23.15.mp4