Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

feat: introduce onRawSubmit and parseSubmitException #150

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

chambo-e
Copy link
Contributor

Summary

  • onRawSubmit: same as bare final-form onSubmit, run an onSubmit without integrated lifecycles
  • parseSubmitException: function that take an exception as parameter and return a string which will be inject into FORM_ERROR

Type

  • Feature

@chambo-e chambo-e requested a review from a team March 15, 2022 15:24
@chambo-e chambo-e self-assigned this Mar 15, 2022
@chambo-e chambo-e requested review from adriengibrat and matthprost and removed request for a team March 15, 2022 15:24
@scaleway-bot scaleway-bot temporarily deployed to feat-parse_excpetion March 15, 2022 15:25 Destroyed
Copy link
Collaborator

@matthprost matthprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great solution 👏

It would be nice if we had an explanation in the documentation or as a comment next to each parameter 😄

@chambo-e chambo-e force-pushed the feat/parse_excpetion branch from 83eb81e to 438d029 Compare March 17, 2022 09:45
@chambo-e chambo-e requested a review from matthprost March 17, 2022 09:46
@scaleway-bot scaleway-bot temporarily deployed to feat-parse_excpetion March 17, 2022 09:46 Destroyed
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #150 (de9e96e) into main (fbb91b4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   94.37%   94.42%   +0.04%     
==========================================
  Files          21       21              
  Lines         231      233       +2     
  Branches       23       24       +1     
==========================================
+ Hits          218      220       +2     
  Misses          9        9              
  Partials        4        4              
Impacted Files Coverage Δ
src/components/Form/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb91b4...de9e96e. Read the comment docs.

@chambo-e chambo-e force-pushed the feat/parse_excpetion branch from 438d029 to de9e96e Compare March 21, 2022 15:41
@chambo-e chambo-e merged commit 9459d6b into main Mar 21, 2022
@chambo-e chambo-e deleted the feat/parse_excpetion branch March 21, 2022 16:15
scaleway-bot pushed a commit that referenced this pull request Mar 21, 2022
## [1.15.0](v1.14.6...v1.15.0) (2022-03-21)

### 📦 Chore

* **devdeps:** update actions/cache action to v3 ([#161](#161)) ([d195070](d195070))
* **devdeps:** update babel monorepo to v7.17.8 ([#157](#157)) ([7a5d239](7a5d239))
* **devdeps:** update dependency @scaleway/eslint-config-react to v3.4.10 ([#160](#160)) ([fbb91b4](fbb91b4))
* **devdeps:** update dependency @types/react-dom to v17.0.14 ([#158](#158)) ([1110bd2](1110bd2))
* **devdeps:** update dependency prettier to v2.6.0 ([#159](#159)) ([8cbdcbe](8cbdcbe))

### ⚙️ Features

* introduce onRawSubmit and parseSubmitException ([#150](#150)) ([9459d6b](9459d6b))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants