This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: introduce onRawSubmit and parseSubmitException #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthprost
suggested changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great solution 👏
It would be nice if we had an explanation in the documentation or as a comment next to each parameter 😄
philibea
approved these changes
Mar 17, 2022
83eb81e
to
438d029
Compare
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 94.37% 94.42% +0.04%
==========================================
Files 21 21
Lines 231 233 +2
Branches 23 24 +1
==========================================
+ Hits 218 220 +2
Misses 9 9
Partials 4 4
Continue to review full report at Codecov.
|
matthprost
approved these changes
Mar 21, 2022
438d029
to
de9e96e
Compare
scaleway-bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
## [1.15.0](v1.14.6...v1.15.0) (2022-03-21) ### 📦 Chore * **devdeps:** update actions/cache action to v3 ([#161](#161)) ([d195070](d195070)) * **devdeps:** update babel monorepo to v7.17.8 ([#157](#157)) ([7a5d239](7a5d239)) * **devdeps:** update dependency @scaleway/eslint-config-react to v3.4.10 ([#160](#160)) ([fbb91b4](fbb91b4)) * **devdeps:** update dependency @types/react-dom to v17.0.14 ([#158](#158)) ([1110bd2](1110bd2)) * **devdeps:** update dependency prettier to v2.6.0 ([#159](#159)) ([8cbdcbe](8cbdcbe)) ### ⚙️ Features * introduce onRawSubmit and parseSubmitException ([#150](#150)) ([9459d6b](9459d6b))
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onRawSubmit
: same as bare final-formonSubmit
, run an onSubmit without integrated lifecyclesparseSubmitException
: function that take an exception as parameter and return a string which will be inject into FORM_ERRORType