scalafmt 3.9.0 doesn't format code with minimal configuration

[Gedochao]

Required: Configuration

version = "3.9.0"
runner.dialect = scala213

version = "3.9.0"
runner.dialect = scala212

version = "3.9.0"
runner.dialect = scala3

Required: Command-line parameters

none

Steps

Given code like this:

package foo

object Foo       extends       java.lang.Object  {
  def           get()             = 2
}

Problem

Scalafmt 3.9.0 formats code like this (as in, seemingly not at all):

package foo

object Foo       extends       java.lang.Object  {
  def           get()             = 2
}

Expectation

I would like the formatted output to look like this (3.8.6 and before did so):

package foo

object Foo extends java.lang.Object {
  def get() = 2
}

Notes

Even when setting the version to 3.8.6 in the configuration, using the newest scalafmt-cli launcher (3.9.0) seems to not format the code.

version = "3.8.6"
runner.dialect = scala3

Discovered while bumping scalafmt in scala-cli:

• Update scalafmt-cli_2.13, scalafmt-core to 3.9.0 VirtusLab/scala-cli#3507

[kitbellew]

Discovered while bumping scalafmt in scala-cli:

• Update scalafmt-cli_2.13, scalafmt-core to 3.9.0 VirtusLab/scala-cli#3507

what exactly in that pr suggests the formatter behaves that way? all i see is it removes trailing whitespace, something that @tgodzik already reported in #4825.

[Gedochao]

Discovered while bumping scalafmt in scala-cli:

• Update scalafmt-cli_2.13, scalafmt-core to 3.9.0 VirtusLab/scala-cli#3507

what exactly in that pr suggests the formatter behaves that way? all i see is it removes trailing whitespace, something that @tgodzik already reported in #4825.

integration.test.jvm 9 tests failed: 
  scala.cli.integration.FmtTests.simple scala.cli.integration.FmtTests.simple
  scala.cli.integration.FmtTests.no inputs scala.cli.integration.FmtTests.no inputs
  scala.cli.integration.FmtTests.with --check scala.cli.integration.FmtTests.with --check
  scala.cli.integration.FmtTests.filter correctly with --check scala.cli.integration.FmtTests.filter correctly with --check
  scala.cli.integration.FmtTests.--save-scalafmt-conf scala.cli.integration.FmtTests.--save-scalafmt-conf
  scala.cli.integration.FmtTests.--scalafmt-dialect scala.cli.integration.FmtTests.--scalafmt-dialect
  scala.cli.integration.FmtTests.creating workspace conf file scala.cli.integration.FmtTests.creating workspace conf file
  scala.cli.integration.FmtTests.scalafmt conf without version scala.cli.integration.FmtTests.scalafmt conf without version
  scala.cli.integration.FixTestsDefault.semantic rule scala.cli.integration.FixTestsDefault.semantic rule

the test cases are here:
https://github.com/VirtusLab/scala-cli/blob/bf3753e433f8020c24dd6e66dfb0c0dc3dddbb81/modules/integration/src/test/scala/scala/cli/integration/FmtTests.scala#L7

not sure if it's the same thing as #4825

[tgodzik]

Looks like the 3.9.0 runner doesn't do anything currently. Running with 3.8.6 runner and new version set does work.

[Gedochao]

That would explain it, since Scala CLI downloads the runner associated with the version.

[kitbellew]

@Gedochao the issue you are reporting is with scala-cli, not scalafmt, correct? and what you are observing is that the way scala-cli uses scalafmt doesn't work, would that be accurate?

3.9.0 CLI is not perfect (reads a lot of files first before starting to format, and does not exit if there are exceptions) but it does format. at least in my testing.

so, perhaps, the way to use it in scala-cli should change, now that scalafmt is asynchronous?

[Gedochao]

@Gedochao the issue you are reporting is with scala-cli, not scalafmt, correct? and what you are observing is that the way scala-cli uses scalafmt doesn't work, would that be accurate?

No. I can replicate the issue with the scalafmt launcher itself.

@kitbellew note that if you use an older scalafmt launcher (3.8.6) with .scalafmt.conf pointing at 3.9.0, it will actually work fine. If you use the newest launcher, however, the issue I describe occurs.

What Scala CLI does is it downloads the launcher matching the scalafmt version in the configuration and runs that.
The issue lies with the scalafmt launcher.

[kitbellew]

No. I can replicate the issue with the scalafmt launcher itself.

How, specifically? Without scala-cli, preferably.

@kitbellew note that if you use an older scalafmt launcher (3.8.6) with .scalafmt.conf pointing at 3.9.0, it will actually work fine. If you use the newest launcher, however, the issue I describe occurs.

Clearly, I used the actual 3.9.0, coursier-installed and also locally built, via sbt cli/assembly, they both work for me. With and without the matching version in configuration.

[kitbellew]

What Scala CLI does is it downloads the launcher matching the scalafmt version in the configuration and runs that. The issue lies with the scalafmt launcher.

what do you mean by "launcher"? do you mean the scalafmt-cli package or something else?

and what do you mean by "runs that"? do you run it by creating a new process and running the executable above? or are you loading the jar and invoking the main method directly?

[tgodzik]

For me what I did was:
cs install scalafmt:3.9.0 and then scalafmt . which didn't fix the file.

After doing cs install scalafmt:3.8.6 it started working again.

[kitbellew]

For me what I did was: cs install scalafmt:3.9.0 and then scalafmt . which didn't fix the file.

After doing cs install scalafmt:3.8.6 it started working again.

@tgodzik I did the same :( in this repository, specifically, I added some spaces here and there and ran the coursier-installed scalafmt. And it worked.

Which repo did you use? What's the config file there? Are there any files which cannot be formatted (bad scala or search state exploding etc.)?

[tgodzik]

Huh, the file was very simple:

//> using scala "3.6.3"
//> using dep "org.scala-lang:scala3-compiler_3:3.6.3"

package foo

object Foo       extends       java.lang.Object  {
  def           get()             = 2
}

I can try and dig in tomorrow to see what is going on.

[Gedochao]

No. I can replicate the issue with the scalafmt launcher itself.

How, specifically? Without scala-cli, preferably.

@kitbellew cs install scalafmt:3.9.0, same as @tgodzik.

[kitbellew]

please check https://github.com/scalameta/scalafmt/releases/tag/v3.9.1

[tgodzik]

Looks to be working both native image and Scala native. Thanks!