Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists exercise expects String Type instead of List #20

Closed
idarlington opened this issue Jun 17, 2016 · 3 comments
Closed

Lists exercise expects String Type instead of List #20

idarlington opened this issue Jun 17, 2016 · 3 comments
Labels
bug Something isn't working

Comments

@idarlington
Copy link
Contributor

idarlington commented Jun 17, 2016

def reuseTailsLists(res0: Int, res1: Int, res2: Int, res3: String, res4: String, res5: String) {
    val d = Nil
    val c = 3 :: d
    val b = 2 :: c
    val a = 1 :: b

    a should be(List(res0, res1, res2))
    a.tail should be(res3)
    b.tail should be(res4)
    c.tail should be(res5)
  }

The above function in the List Section should be refactored to expect

a.tail should be List(2, 3)
b.tail should be List(3)
c.tail should be List[Int]()

and the argument type should be List[Int]

@idarlington
Copy link
Contributor Author

Hi @raulraja what do you think?

@raulraja
Copy link
Member

Looks good, care to submit a PR? We credit contributors by showing their Github profile in the SE Section UI. Thanks!

@raulraja raulraja added the bug Something isn't working label Jun 24, 2016
@idarlington
Copy link
Contributor Author

Ok, I would do a PR.

@ghost ghost closed this as completed Jun 27, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants