Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper config path on Linux #261

Closed
Ape opened this issue Jan 4, 2025 · 1 comment · Fixed by #255 or sblantipodi/glow_worm_luciferin#72
Closed

Proper config path on Linux #261

Ape opened this issue Jan 4, 2025 · 1 comment · Fixed by #255 or sblantipodi/glow_worm_luciferin#72
Assignees
@sblantipodi
Labels
enhancement New feature or request feature request keep don't stale this issue

Comments

@Ape
Copy link
Contributor

Ape commented Jan 4, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe

Currently the config path is ~/Documents/FireflyLuciferin. This is not really acceptable on Linux. ~/Documents is reserved for user files and should never be used for automatic application data.

Describe the solution you'd like

The proper config path on Linux is $XDG_CONFIG_HOME/firefly-luciferin, where $XDG_CONFIG_HOME should default to ~/.config if not set.

I guess we should still search the current path for config files to not break existing setups.
@sblantipodi sblantipodi added the keep don't stale this issue label Jan 4, 2025
@sblantipodi
Copy link
Owner

I agree on this.
Luciferin uses the "Documents" folder because Documents is the appropriate path for Windows app data and Luciferin was born on Windows.

Adding the keep button, I have already developed a mechanism to move the old config to a new path,
so it will not take much effort to correct this.

@sblantipodi sblantipodi added enhancement New feature or request feature request labels Jan 4, 2025
@sblantipodi sblantipodi mentioned this issue Jan 4, 2025
Merged
sblantipodi added a commit that referenced this issue Jan 4, 2025
@sblantipodi
Closes #261
26fe291
@sblantipodi sblantipodi linked a pull request Jan 4, 2025 that will close this issue
small_bugfix #255
Merged
This was referenced Jan 4, 2025
Merged
Merged
sblantipodi added a commit to sblantipodi/glow_worm_luciferin that referenced this issue Jan 4, 2025
@sblantipodi
2025 first release (#72)
4193e3d 
- ***Breaking changes***: requires `Firefly Luciferin` firmware (v2.19.3).   
- The priority of UDP packets in wireless mode has been increased to signal to the router that Luciferin traffic requires lower latency than standard packets.
- If the microcontroller is temporarily disconnected from the WiFi network, Firefly Luciferin is now able to reconnect much faster without restarting the screen capture.
- Added a 'bottom' capture option for [satellites](https://github.com/sblantipodi/firefly_luciferin/wiki/Surround-lighting-with-satellites) when the LEDs are configured to use a bottom gap.
- The [save state](https://github.com/sblantipodi/firefly_luciferin/wiki/Remote-Access#luciferin-web-interface) has been restructured. Auto-save has been disabled to prevent wear on the microcontroller's memory. Closes [#249](sblantipodi/firefly_luciferin#249).
- Arch Linux package. Note: AUR package is built from the official sources but it's currently maintained by @Ape. Closes [#246](sblantipodi/firefly_luciferin#246). Thanks @Ape for this.
- Libasound2t64 dependency prevents correct installation on some Linux distros. Closes [#253](sblantipodi/firefly_luciferin#253).
- Properly handle expired restore token on Wayland. Closes [#259](sblantipodi/firefly_luciferin#259). Thanks @Ape for the PR.
- Logging improvements. Closes [#260](sblantipodi/firefly_luciferin#260). Thanks @Ape for the PR.
- Proper config path on Linux. Config file and logs has been moved in XDG_CONFIG_HOME (~/.config/FireflyLuciferin). Old config files will be automatically moved to the new path. Closes [#261](sblantipodi/firefly_luciferin#261). 
- The snap version was crashing at startup when there were temporary files created by other instances of Firefly Luciferin on the system. Fixed.
sblantipodi added a commit that referenced this issue Jan 4, 2025
@sblantipodi
small_bugfix (#255)
2786dcc 
- ***Breaking changes***: requires `Glow Worm Luciferin` firmware (v5.18.2).   
- The priority of UDP packets in wireless mode has been increased to signal to the router that Luciferin traffic requires lower latency than standard packets.
- If the microcontroller is temporarily disconnected from the WiFi network, Firefly Luciferin is now able to reconnect much faster without restarting the screen capture.
- Added a 'bottom' capture option for [satellites](https://github.com/sblantipodi/firefly_luciferin/wiki/Surround-lighting-with-satellites) when the LEDs are configured to use a bottom gap.
- The [save state](https://github.com/sblantipodi/firefly_luciferin/wiki/Remote-Access#luciferin-web-interface) has been restructured. Auto-save has been disabled to prevent wear on the microcontroller's memory. Closes [#249](#249).
- Arch Linux package. Note: AUR package is built from the official sources but it's currently maintained by @Ape. Closes [#246](#246). Thanks @Ape for this.
- Libasound2t64 dependency prevents correct installation on some Linux distros. Closes [#253](#253).
- Properly handle expired restore token on Wayland. Closes [#259](#259). Thanks @Ape for the PR.
- Logging improvements. Closes [#260](#260). Thanks @Ape for the PR.
- Proper config path on Linux. Config file and logs has been moved in XDG_CONFIG_HOME (~/.config/FireflyLuciferin). Old config files will be automatically moved to the new path. Closes [#261](#261). 
- The snap version was crashing at startup when there were temporary files created by other instances of Firefly Luciferin on the system. Fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sblantipodi sblantipodi

Labels
enhancement New feature or request feature request keep don't stale this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

small_bugfix sblantipodi/firefly_luciferin
2025 first release sblantipodi/glow_worm_luciferin
2 participants
@Ape @sblantipodi