Infinite "tx draft has expired" error

[andywer]

As seen on one device during the launch party:

Error occured once and then appeared immediately again whenever the user tried to create a new payment. Looks as if either no new tx is created or the SubmissionProgress is stuck at the previous state.

[ebma]

I tested it with payments, trading and adding assets. Every time I force a 'Transaction draft has expired' error by exceeding the transaction timeout that we set on transaction creation, I have to close the submission progress dialog and get back to the form (trading, payment or add asset).
So I always have to submit again. And I looked it up, we do create a new transaction every time the user hits submit:

solar/src/components/Payment/PaymentForm.tsx

Line 348 in 4264561

props.onSubmit((horizon, account) => createPaymentTx(horizon, account, formValues))

.

So it has to do something with the SubmissionProgress (?) but I was not able to reproduce this even once so... I don't know.
@andywer are you able to reproduce?

[andywer]

Do we actually fetch a timestamp from horizon? Otherwise maybe it could be an inacurate user device time.

[ebma]

Seems like you're right about the inaccurate time of the user device.
Although we fetch the timebounds from horizon before we create a new transaction, the result seems to be based on the local user time.
(I tested it on android and macOS by setting the time back by a few hours and the fetched timebounds were calculated correctly but based on that modified time.)

I found this related issue ticket which points out that there is a bug in the sdk.

[andywer]

@andrenarchy is on it. I guess it will be fixed with the next horizon update.

(The actual fix is adding an access-control-expose-headers header to the response)

[andywer]

Should be fixed with the upcoming v0.24.0. Horizon servers are sending the correct headers now and Solar will use the latest Stellar SDK containing a fix that will make the feature actually work.