Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position is frustrating when navigating between results page and mod detail #42

Open
cridenour opened this issue Jan 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@cridenour
Copy link

One thing I was hoping would be fixed when I saw the announcement of the update (but persists) is that the page scroll doesn't work like you would expect. If I am scrolled down a page, the mod detail page is scrolled down as well, requiring me to scroll up. Then I go back, and I've lost my place on the results page.

It's a classic symptom of using a SPA. At the very least, I believe the detail page should reset scroll to the top.

There is a setting under window.history.scrollRestoration which you can set to auto which may help on the results back behavior, but it just depends on how the libraries are implemented.

@budak7273 budak7273 moved this to 👀 In review in Mod Repository (SMR) Jun 11, 2023
@budak7273 budak7273 moved this from 👀 In review to 🆕 New in Mod Repository (SMR) Jun 11, 2023
@budak7273
Copy link
Member

@cridenour Is this still an issue? On Firefox, when I navigate from results->detail, my scroll is reset to the top. Navigating from a scrolled description pane to Mods still keeps the detail page's scroll position, though.

@cridenour
Copy link
Author

@cridenour Is this still an issue? On Firefox, when I navigate from results->detail, my scroll is reset to the top. Navigating from a scrolled description pane to Mods still keeps the detail page's scroll position, though.

It does seem to be broken for me still, also on Firefox. Sometimes it does scroll to the top when navigating to detail but its not consistent which makes me think its only happening if the detail didn't load in time so the container was smaller than the results and was forced to scroll up. Navigating back definitely loses scroll position though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants