unrecognized psuedos with arguments parse as declaration-values #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think you might need to enable some sass-spec tests to make sure this is working. |
|
Yes PR for that coming soon, took me a bit to get the repo setup, but I think I've got it now. We'll send over |
mgreter
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#1462
fixes #2424, fixes #2944 I think.
Not a c++ dev so please forgive me if this is bad 🙏 It seems to work, i've added a few tests and removed some existing TODO's but i guess i need to PR those to the spec repo directly. I'm not sure on the order of operations on that...
I didn't know know how to parse the unknown case, so reused the css custom variable logic since I think they should be the same, or close?