Skip to content

Commit

Permalink
bump version
Browse files Browse the repository at this point in the history
  • Loading branch information
@darrenkopp
darrenkopp committed Oct 3, 2014
1 parent 3c0669f commit 94abbd7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion libsassnet/libsassnet.nuspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package>
<metadata>
<id>$id$</id>
<version>1.8</version>
<version>1.9</version>
<authors>Darren Kopp</authors>
<owners>Darren Kopp</owners>
<licenseUrl>https://github.com/darrenkopp/libsass-net/blob/master/LICENSE</licenseUrl>
Expand Down
2 changes: 1 addition & 1 deletion libsassnet/libsassnet.x64.nuspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package>
<metadata>
<id>$id$.x64</id>
<version>1.8</version>
<version>1.9</version>
<authors>Darren Kopp</authors>
<owners>Darren Kopp</owners>
<licenseUrl>https://github.com/darrenkopp/libsass-net/blob/master/LICENSE</licenseUrl>
Expand Down

8 comments on commit 94abbd7

@am11
Copy link
Contributor

@am11 am11 commented on 94abbd7 Oct 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, FYI, there are couple of changes recently been made in libsass interface and few additions.

Such as:

  • Addition of omit_source_map_url option (to remove source-mapping-url comment from generated CSS, even when map file is created).
  • Couple of options are made bool in interface. It's C99 bool, which means it would take VS2013 Update 3+ VCR to compile.

See those change structs here: https://github.com/sass/libsass/blob/9569ba15a3b9d04be1490f6d83c998802cd94514/sass_interface.h#L18-L77. (code is with comments now 😃)

Thank you for making .NET wrapper for libsass. I hope it will be kept up-to-date (unlike other outdated ones on nuget.org). 👍

@darrenkopp
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks for the heads up. yeah, this one should be pretty easy to keep up to date because for the most part i just need to pull latest on the submodule and compile. usually works fine, every now and then i have to reconcile issues.

@darrenkopp
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@am11 the migration to 3.0 has been completed and packages uploaded to nuget. 98f4f04

@am11
Copy link
Contributor

@am11 am11 commented on 94abbd7 Oct 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darrenkopp, thanks for the update! 👍

@am11
Copy link
Contributor

@am11 am11 commented on 94abbd7 Oct 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darrenkopp, since we are able to compile libsass without extra guards with Visual Studio 2013 Update 3, can we come up with a nmake file to compile sassc (which libsass uses to run tests)? I have been making releases for node-sass (another libsass downstream) with VS2013 without issue. All the C99, C++11 requirements are fulfilled.

Details:

SassC requires two POSIX guards: unistd.h and getopt.h. We can use these: unistd: https://gist.github.com/ashelly/7776712 and getopt: https://gist.github.com/ashelly/7776712. I have tested it with VS2013 and sassc locally and they suffice the need.

Matter of fact, I am trying to configure Appveyor (Windows CI). I first tried with powershell and cmd, but libsass' cibuild script fails it. Now I am trying to do the same with MinGW shell, using GCC. The problem is, it GCC fails to compile, becase it doesn't like isascii() in functions.c. I tried replacing it with standard ctype.h's __isascii(), but then it doesn't like std::tolower/toupper.

Here is my config script so far: https://github.com/am11/sassc/blob/master/appveyor.yml and the CI build is running here: https://ci.appveyor.com/project/am11/sassc. (as you can see I have been hammering it for a while now..)

Appveyor has Perl, Python, Ruby, Node.js, MinGW, VS2010, 2012 and 2013 (Update 3) (the free/express one) installed. So we don't need to setup anything there. That is pretty much we need run those tests. :)

If we have nmake file (or the VS proj file?). Then we can defer it to call VS2013's nmake.exe and build the libsass and sassc code with it.

Thanks in anticipation, if you can help in that regard.

/cc (based on sass/sassc#45 and sass/sassc#5) @QuLogic, @mgreter, @icasteleyn, @PhilT, @Articus

@am11
Copy link
Contributor

@am11 am11 commented on 94abbd7 Oct 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is this ugly hack which I had to use here: https://github.com/am11/sassc/blob/master/appveyor.yml#L17 to fix this mingw bug: http://sourceforge.net/p/mingw/bugs/2024/. So VS2013 is the right tool for compilation there I guess..

@darrenkopp
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, to make sure I'm following here, we are just wanting to make sassc compile with vs 2013, correct?

@am11
Copy link
Contributor

@am11 am11 commented on 94abbd7 Oct 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. And it builds libsass as part of make, which chokes on compile.

Separately, Son of Dragon - v3.0.1 is released. 😄

Please sign in to comment.