Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration file is not readable #59

Closed
sanposhiho opened this issue Sep 3, 2021 · 1 comment
Closed

configuration file is not readable #59

sanposhiho opened this issue Sep 3, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sanposhiho
Copy link
Owner

sanposhiho commented Sep 3, 2021

Now, we support configuration gomockhandler.json.

And to add new mock on config, users have to execute cmd like this, and config for new mock will be added on gomockhandler.json.
gomockhandler -config=/path/to/gomockhandler.json -source=foo.go -destination=./mock/ [other mockgen options]

But, PR reviewers cannot see what command will be registered, and it makes PR review a little hard.

So, I want to add new optional configuration file or add information on config file to resolve this.

@sanposhiho sanposhiho added the enhancement New feature or request label Sep 3, 2021
@sanposhiho sanposhiho self-assigned this Sep 3, 2021
@sanposhiho sanposhiho changed the title support more readable configuration file to generate mock make mockgen command more readable on configuration Sep 17, 2021
@sanposhiho sanposhiho changed the title make mockgen command more readable on configuration configuration file is not readable Nov 12, 2021
@sanposhiho
Copy link
Owner Author

sanposhiho commented Nov 12, 2021

I think we can resolve this by splitting gomockhandler.json into two file. The one is to manage mock information (= configuration file) and the other one is to manage the status of each mock.
With this, we can make configuration file(the first one) more readable. And we can allow user to edit configuration file directly (= user can edit configuration without CLI)

close this issue and open another enhancement issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant