fix: remove incorrect autocomplete from GROQ #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cngonzalez
requested review from
a team and
binoy14
and removed request for
a team
binoy14
approved these changes
Mar 13, 2024
|
maybe changing the commit to something along the lines of |
cngonzalez
changed the title
cngonzalez
requested review from
bjoerge and
rexxars
and removed request for
bjoerge
|
Tagging @rexxars who's maintained some of these dependencies just in case he catches anything undesirable about this approach. |
rexxars
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES SDX-1176
Per one of the mantainers of the CodeMirror package, removing the undesired autocomplete behavior means removing the support package of the language.
I've done that in this PR. I'm not intimately familiar with CodeMirror, but it seems only including the parser is what we need here, since we're NOT in a javascript context but want indentation, highlighting, and other behaviors. That's what I observed is maintained from manual testing, but would love some eyes on any gotchas.