From fcdedf75a438009e28be5827670190db17001167 Mon Sep 17 00:00:00 2001 From: Damien L-G Date: Thu, 23 Feb 2023 17:41:41 -0500 Subject: [PATCH] Do not bother with sycl::rotate --- core/src/Kokkos_BitManipulation.hpp | 34 ++--------------------------- 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/core/src/Kokkos_BitManipulation.hpp b/core/src/Kokkos_BitManipulation.hpp index 1f173224e2..b54be3b301 100644 --- a/core/src/Kokkos_BitManipulation.hpp +++ b/core/src/Kokkos_BitManipulation.hpp @@ -304,34 +304,6 @@ KOKKOS_IMPL_HOST_FUNCTION #undef KOKKOS_IMPL_USE_GCC_BUILT_IN_FUNCTIONS -template -KOKKOS_FUNCTION T rotl_builtin_host(T x, int s) noexcept { - return rotl(x, s); -} - -template -KOKKOS_FUNCTION T rotl_builtin_device(T x, int s) noexcept { -#ifdef KOKKOS_ENABLE_SYCL - return sycl::rotate(x, s); -#else - return rotl(x, s); -#endif -} - -template -KOKKOS_FUNCTION T rotr_builtin_host(T x, int s) noexcept { - return rotr(x, s); -} - -template -KOKKOS_FUNCTION T rotr_builtin_device(T x, int s) noexcept { -#ifdef KOKKOS_ENABLE_SYCL - return sycl::rotate(x, -s); -#else - return rotr(x, s); -#endif -} - } // namespace Kokkos::Impl namespace Kokkos::Experimental { @@ -411,16 +383,14 @@ template [[nodiscard]] KOKKOS_FUNCTION std::enable_if_t<::Kokkos::Impl::is_standard_unsigned_integer_type_v, T> rotl_builtin(T x, int s) noexcept { - KOKKOS_IF_ON_DEVICE((return ::Kokkos::Impl::rotl_builtin_device(x, s);)) - KOKKOS_IF_ON_HOST((return ::Kokkos::Impl::rotl_builtin_host(x, s);)) + return rotl(x, s); // no benefit to call the _builtin variant } template [[nodiscard]] KOKKOS_FUNCTION std::enable_if_t<::Kokkos::Impl::is_standard_unsigned_integer_type_v, T> rotr_builtin(T x, int s) noexcept { - KOKKOS_IF_ON_DEVICE((return ::Kokkos::Impl::rotr_builtin_device(x, s);)) - KOKKOS_IF_ON_HOST((return ::Kokkos::Impl::rotr_builtin_host(x, s);)) + return rotr(x, s); // no benefit to call the _builtin variant } } // namespace Kokkos::Experimental