Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications related to Hessian dot Product capabilities #724

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

mperego
Copy link
Collaborator

@mperego mperego commented Jul 29, 2021

Modified ModelEvaluator and tests to comply with the new syntax for defining the Hessian Dot Product (trilinos/Trilinos#9501).

@mperego mperego requested a review from kliegeois July 29, 2021 13:18
@mperego mperego force-pushed the hessian_dot_product branch from 4494cc1 to 8af311e Compare July 29, 2021 14:30
Copy link
Contributor

@kliegeois kliegeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me; thanks for the if statement in the CMakeLists.txt!

mperego added 2 commits July 29, 2021 15:13
Use the new syntax for defining Hessian Dot Product in the tests
(removed "Hessian Dot Product" when not used, e.g. in Epetra builds)

Enabled by default the Thyra support for the AD construction of H_pp
@mperego mperego force-pushed the hessian_dot_product branch from 9c4291f to 92a4e6a Compare July 29, 2021 21:30
@mperego mperego merged commit 94db7d1 into master Jul 29, 2021
@mperego mperego deleted the hessian_dot_product branch July 29, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants