Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please vendor go-ethereum #232

Open
karalabe opened this issue Nov 21, 2017 · 1 comment
Open

Please vendor go-ethereum #232

karalabe opened this issue Nov 21, 2017 · 1 comment

Comments

@karalabe
Copy link

Hey there!

We'll be introducing a breaking API change in go-ethereum 1.8.0, changing GasUsed and GasLimit types in our entire codebase from big.Int to uint64 ethereum/go-ethereum#15466. This will probably break your code if it's not vendored in.

My suggestion is to vendor it the current go-ethereum code, then when we update to uint64 you can check the couple lines that need to be updated.

Cheers,
Peter
@mikeyb mikeyb mentioned this issue Dec 1, 2017
Closed
@sammy007
Copy link
Owner

sammy007 commented Dec 3, 2017

I'll just update if it breaks. I don't remember that any of these types used, only ethash which is sealed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karalabe @sammy007