Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why does the middleware returns plain error? #38

Closed
uzzz opened this issue Jul 16, 2024 · 4 comments
Closed

Question: why does the middleware returns plain error? #38

uzzz opened this issue Jul 16, 2024 · 4 comments

Comments

@uzzz
Copy link

uzzz commented Jul 16, 2024

Hi!

Nice project and good job.

However, there is one thing I can't get: why the middleware turns echo.HTTPError into a plain error here? It breaks the default echo's error handler behaviour and any error ends up as 500 if slog-echo is used. Hope you can help me understand the rationale behind this decision.

@taraktikos
Copy link

I faced with the same issue. After upgrading to 1.14.3 it starts convert all errors to 500

@samber
Copy link
Owner

samber commented Jul 22, 2024

-> v1.14.4

Thanks for the fix!

@uzzz
Copy link
Author

uzzz commented Jul 22, 2024

Thanks! Closing the issue

@uzzz uzzz closed this as completed Jul 22, 2024
@abh
Copy link
Contributor

abh commented Jul 22, 2024

Ha, I hadn't seen this -- it'd have saved me some debugging time if I'd looked! Thanks for merging #39 so quick. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants