Change the delimeters to prevent possible tracebacks on some packages with dpkg_lowpkg #62519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
requested review from
garethgreenaway
and removed request for
a team
vzhestkov
force-pushed
the
fix-dpkg-_get_pkg_info
branch
6 times, most recently
from
f95416d to
e83aab6
Compare
vzhestkov
force-pushed
the
fix-dpkg-_get_pkg_info
branch
from
e83aab6 to
396c76f
Compare
3 tasks
meaksh
approved these changes
Aug 31, 2022
garethgreenaway
approved these changes
Sep 2, 2022
Ch3LL
approved these changes
Sep 7, 2022
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
… with dpkg_lowpkg * Use another separator on query to dpkg-query * Fix the test test_dpkg_lowpkg::test_info BACKPORT-UPSTREAM=saltstack#62519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dpkg_lowpkgis using------and======as a delimiters while callingdpkg-queryto get the information about the packages. The problem here that some of the packages have such delimiters in the description field what causing tracebacks on attempt to get the package information.The packages causing this issues (tested on Ubuntu 20.04):
libencode-eucjpms-perlandowncloud-client.Previous Behavior
Possible tracebacks in case if there is a package with
------or======in the description is installed on the minion.New Behavior
Normal behavior
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.