-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] salt-call x509.read_certificate error out when reading a Microsoft CA issued certificate #57535
Comments
There is a PR in with m2crypto that builds wheels, but it hasn't been merged. Hopefully that will resolve this issue. see https://gitlab.com/m2crypto/m2crypto/-/merge_requests/245 |
@dmurphy18 can you reference the PR? |
Tried with latest Saltstack release and latest m2crypto, the issue still persists.
Is there a plan to workaround this from Saltstack side? |
The Core Team will not be able to get this in this release cycle and moving this back into planning. |
Description
When using salt-call x509.read_certificate to read a Microsoft CA issued certificate, it will error out due to an exception raised in m2crypto library for unsupported format.
I've also raised https://gitlab.com/m2crypto/m2crypto/-/issues/276 to address the issue
Setup
Steps to Reproduce the behavior
Expected behavior
To print out decodable content of the certificate and display out
Screenshots
If applicable, add screenshots to help explain your problem.
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)Additional context
Can add a try catch exception at https://github.com/saltstack/salt/blob/master/salt/modules/x509.py#L607, as some elements in the list is empty(not decodable by m2crypt) and cause an exception
The code to use M2Crypto module
Run result
The text was updated successfully, but these errors were encountered: