Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore 1.2.x timing for config calculation #186

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

dfreeman
Copy link
Member

@dfreeman dfreeman commented Apr 7, 2020

This will fix #166 (or at least the original error reported there). Now, a typo in an import path will no longer give the cryptic error message:

Unable to resolve styles from addon ; is it installed?

Instead, devs will see:

Unable to resolve styles module 'oops/a/typo' imported from
'<importing file>.css'. No virtual module with that name was
defined and no corresponding addon was found.

It also updates the guidance in the virtual modules documentation due to the config calculation timing changes that were necessary to support component/template colocation.

Also update the advice for dynamically configuring virtual modules.
@dfreeman dfreeman changed the title Improve error message for missing external module. Improve error message for missing external module, restore 1.2.x timing for config calculation Apr 8, 2020
@dfreeman dfreeman changed the title Improve error message for missing external module, restore 1.2.x timing for config calculation Restore 1.2.x timing for config calculation Apr 8, 2020
@dfreeman
Copy link
Member Author

dfreeman commented Apr 8, 2020

This PR should now fix #166 completely—it both addresses the awful error message and restores the timing of options calculation back to the way it works in the current stable release. I'm aiming to get another beta release out either today or tomorrow (depending on how some of the Embroider stuff shakes out) and this will be included in that.

@dfreeman dfreeman merged commit c55e655 into master Apr 8, 2020
@dfreeman dfreeman deleted the improve-missing-module-error-message branch April 8, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building addon with 1.3.0-beta.1 fails with message Unable to resolve styles from addon ; is it installed?
1 participant