Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta ember-cli-babel versions trigger error #5

Closed
jrjohnson opened this issue Mar 16, 2017 · 5 comments
Closed

Beta ember-cli-babel versions trigger error #5

jrjohnson opened this issue Mar 16, 2017 · 5 comments

Comments

@jrjohnson
Copy link

I'm seeing:

$ ember dependency-lint
ember-cli-babel
Allowed: *
Found: 5.2.4, 6.0.0-beta.5, 5.1.10

As https://github.com/machty/ember-maybe-import-regenerator is now requiring the beta bower version.

@kturney
Copy link

kturney commented Mar 16, 2017

Just ran into this as well.

This is apparently the semver lib working as designed.

I worked around the issue with:

// config/dependency-lint.js

module.exports = {
  allowedVersions: {
    'ember-cli-babel': '* || >=6.0.0-beta.1'
  }
};

@dfreeman
Copy link
Member

Ran into this about an hour ago as well. @kturney's suggestion will work as a workaround for the moment, but I'm leaning toward special-casing a version constraint of '*' within this addon to bypass semver.satisfies completely and just truly accept anything.

Seem reasonable?

@kturney
Copy link

kturney commented Mar 16, 2017

@dfreeman seems reasonable to me

@jrjohnson
Copy link
Author

Yes. I think * should mean *. Sounds good.

@dfreeman
Copy link
Member

Fixed in v1.0.2 — thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants