From 7ee4f6cc062d01579fc41c9dc15c938a48aba487 Mon Sep 17 00:00:00 2001 From: Sotonye Atemie Date: Sun, 2 Mar 2025 15:07:07 -0500 Subject: [PATCH] Delay setting up Qt signals for the sliders until the initial assignment has completed --- src/gui/modals/SetupDialog.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gui/modals/SetupDialog.cpp b/src/gui/modals/SetupDialog.cpp index 349d74141b4..8cc8f3cd936 100644 --- a/src/gui/modals/SetupDialog.cpp +++ b/src/gui/modals/SetupDialog.cpp @@ -562,11 +562,11 @@ SetupDialog::SetupDialog(ConfigTab tab_to_open) : auto sampleRateBox = new QGroupBox{tr("Sample rate"), audio_w}; - m_sampleRateSlider = new QSlider{Qt::Horizontal, sampleRateBox}; + m_sampleRateSlider = new QSlider{Qt::Horizontal}; m_sampleRateSlider->setRange(0, SUPPORTED_SAMPLERATES.size() - 1); m_sampleRateSlider->setTickPosition(QSlider::TicksBelow); - auto sampleRateResetButton = new QPushButton{embed::getIconPixmap("reload"), "", sampleRateBox}; + auto sampleRateResetButton = new QPushButton{embed::getIconPixmap("reload"), ""}; sampleRateResetButton->setFixedSize(32, 32); auto sampleRateSubLayout = new QHBoxLayout{}; @@ -586,18 +586,16 @@ SetupDialog::SetupDialog(ConfigTab tab_to_open) : m_sampleRate = SUPPORTED_SAMPLERATES[index]; m_sampleRateSlider->setValue(index); sampleRateLabel->setText(tr("Sample rate: %1").arg(m_sampleRate)); - - showRestartWarning(); }; + setSampleRate(m_sampleRate); + connect(m_sampleRateSlider, &QSlider::valueChanged, this, [setSampleRate](int value) { setSampleRate(SUPPORTED_SAMPLERATES[value]); }); connect(sampleRateResetButton, &QPushButton::clicked, this, [setSampleRate] { setSampleRate(SUPPORTED_SAMPLERATES.front()); }); - setSampleRate(m_sampleRate); - // Buffer size group QGroupBox * bufferSizeBox = new QGroupBox(tr("Buffer size"), audio_w); QVBoxLayout * bufferSizeLayout = new QVBoxLayout(bufferSizeBox);