Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to release info gone #484

Closed
dimpase opened this issue Dec 13, 2024 · 4 comments · Fixed by #485
Closed

link to release info gone #484

dimpase opened this issue Dec 13, 2024 · 4 comments · Fixed by #485

Comments

@dimpase
Copy link
Member

dimpase commented Dec 13, 2024

specifically, for the current release: https://github.com/sagemath/sage/wiki/Sage-10.5-Release-Tour
@haraldschilly

@haraldschilly
Copy link
Member

Can you specify the page and since when to narrow this down? I searched through recent commits and the first one I found could be 89419d6

@dimpase
Copy link
Member Author

dimpase commented Dec 16, 2024

I don't think it will be sufficient to revert this one. Namely, we should create a Wiki "page" - like the ones in the column on the RHS of the page, and move all the release tours there. And add a link to this page to the main webpages, here. But I don't get how to create such a "wiki page". Perhaps after more sleep...

@dimpase
Copy link
Member Author

dimpase commented Dec 16, 2024

OK, I'm working on moving the release tours to a separate wiki page: https://github.com/sagemath/sage/wiki/Release-Tours
So just add a link to this URL somewhere near releases info?

EDIT: done. So just add the link please

@dimpase
Copy link
Member Author

dimpase commented Dec 16, 2024

Something like this:

diff --git a/src/index.html b/src/index.html
index 4240825..ae9e7d4 100644
--- a/src/index.html
+++ b/src/index.html
@@ -145,8 +145,10 @@ if (data) {
      <div class="small">
        <span class="nowrap"><a href="https://github.com/sagemath/sage/releases">Releases</a>
          &middot; </span>
-         {#<span class="nowrap"><a href="https://wiki.sagemath.org/ReleaseTours/">Release Tours</a>
-       &middot; </span>#}
+         <span class="nowrap"><a href=""https://github.com/sagemath/sage/wiki/Release-Tours>Release Tours</a>
+       &middot; </span>
+	 <span class="nowrap"><a href=""https://github.com/sagemath/sage/wiki/Sage-{{version}}-Release-Tour>Release Tour for {{version}}</a>
+       &middot; </span>
          {#<span class="nowrap"><a href="changelogs/index.html">Changelogs</a>
        &middot; </span>#}
          {#<span class="nowrap"><a href="download-source.html">Source tarball {{ version_src }}</a>

(I don't know whether one can just insert templates into URLs like this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants