Use ecl-config to determine compiler/linker flags for ecl

Author: tobiasdiez

build/pkgs/sage_conf/src/sage_conf.py.in

@@ -6,6 +6,10 @@ MAXIMA = "@prefix@/bin/maxima"
 
 ARB_LIBRARY = "@SAGE_ARB_LIBRARY@"
 
+# Path to the ecl-config script
+# TODO: At the moment this is hard-coded, needs to be set during the configure phase if we want to support system-installed ecl.
+ECL_CONFIG_PATH = "@prefix@/bin/ecl-config"
+
 SAGE_NAUTY_BINS_PREFIX = "@SAGE_NAUTY_BINS_PREFIX@"
 
 # Colon-separated list of pkg-config modules to search for cblas functionality.

src/sage/env.py

@@ -37,6 +37,7 @@
 import sysconfig
 from . import version
 from pathlib import Path
+import subprocess
 
 
 # All variables set by var() appear in this SAGE_ENV dict and also
@@ -203,6 +204,7 @@ def var(key, *fallbacks, **kwds):
 var('SAGE_NAUTY_BINS_PREFIX',        '')
 var('ARB_LIBRARY',                   'arb')
 var('CBLAS_PC_MODULES',              'cblas:openblas:blas')
+var('ECL_CONFIG_PATH')
 
 # misc
 var('SAGE_BANNER', '')
@@ -458,4 +460,13 @@ def uname_specific(name, value, alternative):
     except ValueError:
         pass
 
+    # Determine ecl-specific compiler arguments using the ecl-config script
+    ecl_cflags = subprocess.run([ECL_CONFIG_PATH, "--cflags"], check=True, capture_output=True, text=True).stdout.split()
+    aliases["ECL_CFLAGS"] = list(filter(lambda s: not s.startswith('-I'), ecl_cflags))
+    aliases["ECL_INCDIR"] = list(map(lambda s: s[2:], filter(lambda s: s.startswith('-I'), ecl_cflags)))
+    ecl_libs = subprocess.run([ECL_CONFIG_PATH, "--libs"], check=True, capture_output=True, text=True).stdout.split()
+    aliases["ECL_LIBDIR"] = list(map(lambda s: s[2:], filter(lambda s: s.startswith('-L'), ecl_libs)))
+    aliases["ECL_LIBRARIES"] = list(map(lambda s: s[2:], filter(lambda s: s.startswith('-l'), ecl_libs)))
+    aliases["ECL_LIBEXTRA"] = list(filter(lambda s: not s.startswith(('-l','-L')), ecl_libs))
+
     return aliases

src/sage/libs/ecl.pxd

@@ -1,4 +1,9 @@
-# distutils: libraries = ecl gmp
+# distutils: extra_compile_args = ECL_CFLAGS
+# distutils: include_dirs = ECL_INCDIR
+# distutils: libraries = ECL_LIBRARIES
+# distutils: library_dirs = ECL_LIBDIR
+# distutils: extra_link_args = ECL_LIBEXTRA
+
 ###############################################################################
 #   Sage: Open Source Mathematical Software
 #       Copyright (C) 2009 Nils Bruin <[email protected]>
@@ -153,4 +158,4 @@ cdef extern from "ecl/ecl.h":
 
     # symbols
 
-    cl_object ecl_make_symbol(const char *name, const char *package)
+    cl_object ecl_make_symbol(const char *name, const char *package)