Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorisation of families #7208

Closed
nthiery opened this issue Oct 14, 2009 · 8 comments
Closed

Refactorisation of families #7208

nthiery opened this issue Oct 14, 2009 · 8 comments
Assignees
@nthiery
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-4.3

Comments

@nthiery
Copy link
Contributor

nthiery commented Oct 14, 2009

Log of the attached patch:

  • Families are parents, in the (Finite/Infinite)EnumeratedSets category
  • New class EnumeratedFamily; Family accept any (Finite)EnumeratedSet as input
  • Improves the output of lazy families, and update accordingly the
    doctests in CombinatorialFreeModule, ...
  • Clean trailing whitespaces
  • Use TestSuite
  • Fix enumeration for FiniteFamily

Depends on #5891

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: Family, enumerated set

Author: Florent Hivert

Reviewer: Nicolas M. Thiéry

Merged: sage-4.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7208
@nthiery nthiery added this to the sage-4.3 milestone Oct 14, 2009
@nthiery nthiery self-assigned this Oct 14, 2009
@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor Author

nthiery commented Oct 16, 2009

comment:4

We should use the occasion to fix this bug:

sage: f = Family(["c", "a", "b"], lambda x: x+x)
sage: list(f)
['aa', 'cc', 'bb']

@nthiery
Copy link
Contributor Author

nthiery commented Oct 16, 2009

comment:5

The updated patch is supposed to fix it. Florent: please review!

@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor Author

nthiery commented Oct 16, 2009

Attachment: trac_7208_family_enumset.patch.gz

@nthiery
Copy link
Contributor Author

nthiery commented Oct 16, 2009

comment:7

Fixed missing doctests

@hivert
Copy link
Contributor

hivert commented Oct 16, 2009

comment:8

Things are now ok :-) Positive review.

Florent

@mwhansen
Copy link
Contributor

Merged: sage-4.3.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nthiery nthiery

Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.3
Development

No branches or pull requests
3 participants
@mwhansen @nthiery @hivert