Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove naive suffix trees #6526

Closed
rlmill mannequin opened this issue Jul 13, 2009 · 7 comments
Closed

remove naive suffix trees #6526

rlmill mannequin opened this issue Jul 13, 2009 · 7 comments
Assignees
@mwhansen
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-4.1.1

Comments

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 13, 2009

This is one of the obstructions to switching the graph backends over to Cython by default.

To quote Franco:

But all the doctest failures occur in the NaiveSuffixTreeClass, which
is a naive implementation. This code was only intended for testing
purposes, so I think it is fine to delete it (delete both
NaiveSuffixTree and NaiveSuffixTreeClass). I am pretty certain it is
not used anywhere else (it should not be, if it is), because it is a
very slow implementation (hence, the name naive).

CC: @saliola

Component: combinatorics

Author: Robert Miller

Reviewer: Franco Saliola

Merged: sage-4.1.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6526
@rlmill rlmill mannequin added this to the sage-4.1.1 milestone Jul 13, 2009
@rlmill rlmill mannequin added c: combinatorics labels Jul 13, 2009
@rlmill rlmill mannequin assigned mwhansen Jul 13, 2009
@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jul 13, 2009

comment:1

This will be based on #6519.

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jul 14, 2009

based on #6519

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jul 14, 2009

comment:2

Attachment: trac_6526-remove-naive-suffix-tree.patch.gz

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jul 14, 2009

Author: Robert Miller

@rlmill rlmill mannequin added the s: needs review label Jul 14, 2009
@saliola
Copy link
Contributor

saliola commented Jul 16, 2009

comment:3

Positive review.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

Merged: sage-4.1.1.alpha0

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

Reviewer: Franco Saliola

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jul 18, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwhansen mwhansen

Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.1.1
Development

No branches or pull requests
2 participants
@mwhansen @saliola