Cleanup of integer compositions

[nthiery]

• Documentation improvements
• Fixes some of http://wiki.sagemath.org/combinat/Weirdness
• Composition(l) accepts any iterable l, and in particular a tuple
• New functionalities:
  • concatenation (as __add__ and sum)
  • size
  • fatter, finer, fatten (refinement of compositions)
• Uses IntegerListsLex (fast iteration, ...) instead of not any better specific code
  Note: this changes the iteration order to inverse lexicographic,
  and iteration changes the iteration order for set partitions, skew
  partitions, and skew tableaux.

CC: @sagetrac-sage-combinat @jbandlow

Component: combinatorics

Keywords: integer compositions

Author: Nicolas M. Thiéry

Reviewer: Dan Drake, Jason Bandlow, Minh Van Nguyen

Merged: Sage 4.1.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/5600

[nthiery]

Changed keywords from none to integer compositions

[nthiery]

comment:6

Attachment: compositions-cleanup-5600-nt.patch.gz

[nthiery]

Reviewer: Dan Drake, Jason Bandlow

[nthiery]

Author: Nicolas M. Thiéry

[nthiery]

comment:8

The updated patch fixes the (the failure was actually actually a trivial thing in the doctest; thanks to Jason for spotting this!)

[nthiery]

Attachment: trac_5600-compositions_cleanup-nt.2.patch.gz

Attachment: trac_5600-compositions_cleanup-nt.patch.gz

Apply only this one, yes, this one!

[jbandlow]

comment:9

Doctests pass, and it looks like Dan's issues have been resolved. Positive review from me.

[sagetrac-mvngu]

Attachment: trac_5600-reviewer.patch.gz

reviewer patch

[sagetrac-mvngu]

comment:10

I'm attaching the reviewer patch trac_5600-reviewer.patch. It fixes a number of typos introduced by trac_5600-compositions_cleanup-nt.patch, and edits some docstrings so they look a bit nicer when one views the corresponding pages in the reference manual. If people are happy with my reviewer patch trac_5600-reviewer.patch, then patches should be merged in this order:

1. trac_5600-compositions_cleanup-nt.patch
2. trac_5600-reviewer.patch

[nthiery]

comment:11

Replying to @sagetrac-mvngu:

I'm attaching the reviewer patch trac_5600-reviewer.patch. It fixes a number of typos introduced by trac_5600-compositions_cleanup-nt.patch, and edits some docstrings so they look a bit nicer when one views the corresponding pages in the reference manual. If people are happy with my reviewer patch trac_5600-reviewer.patch, then patches should be merged in this order:

1. trac_5600-compositions_cleanup-nt.patch
2. trac_5600-reviewer.patch

Thanks much for fixing all those typos! positive review on your reviewer's patch.

[sagetrac-mvngu]

Merged: Sage 4.1.2.alpha0

[sagetrac-mvngu]

Changed reviewer from Dan Drake, Jason Bandlow to Dan Drake, Jason Bandlow, Minh Van Nguyen

[sagetrac-mvngu]

comment:12

Merged patches in this order:

1. trac_5600-compositions_cleanup-nt.patch
2. trac_5600-reviewer.patch