We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
any_root
The trace computation in the helper method _cantor_zassenhaus_split_to_irreducible introduced by #37170 is implemented incorrectly. More specifically, these lines at https://github.com/sagemath/sage/blob/develop/src/sage/rings/polynomial/polynomial_element.pyx#L2176-L2177
_cantor_zassenhaus_split_to_irreducible
if q % 2: h = self.gcd(pow(T, (q-1)//2, self) - 1)
should be
if q % 2: h = self.gcd(pow(T, (q**degree-1)//2, self) - 1)
Proof:
sage: R.<x> = GF(13)[] ....: def irr(d, R): return f.monic() if (f := R.random_element(d)).is_irreducible() else irr(d, R) ....: f = prod(irr(6, R) for _ in range(10)) ....: f.factor()[0][0].degree() ....: f.any_root(degree=6) # errors
don't error
error
We have a fix already
Latest `develop` branch
The text was updated successfully, but these errors were encountered:
any_root()
c1f3652
Successfully merging a pull request may close this issue.
Steps To Reproduce
The trace computation in the helper method
_cantor_zassenhaus_split_to_irreducible
introduced by #37170 is implemented incorrectly. More specifically, these lines at https://github.com/sagemath/sage/blob/develop/src/sage/rings/polynomial/polynomial_element.pyx#L2176-L2177should be
Proof:
Expected Behavior
don't error
Actual Behavior
error
Additional Information
We have a fix already
Environment
Checklist
The text was updated successfully, but these errors were encountered: