-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump giac's GIAC_MIN_VERSION to 1.9 #34857
Comments
comment:1
too old for what? |
comment:2
Because #32354 raised the version of giac needed to 1.7.0-27 but didn't change |
comment:3
ubuntu-jammy (LTS) only has 1.7.0.39, so I think it's better to just raise to some 1.7 version |
comment:4
Replying to Matthias Köppe:
I am OK to raise it to just 1.7.0-27, I cannot think of any other tickets like #32354. |
comment:5
Unfortunately we don't know how to check the patchlevel. |
comment:6
Not even the header have the patch level. I do not think upstream provided a way to figure the patch level. |
comment:7
OK, then let's just use 1.9.0. Given that downstream versions of giac are affected by #33848, it's not a big loss that we have to build our own giac on ubuntu-jammy. |
New commits:
|
Author: Matthias Koeppe |
Commit: |
comment:10
Well, I didn't realise the minimum version of giac was so low. I am not sure 1.5 releases would have work well, even before #32354. That's a rather trivial change. Do we want to keep a check on an upper version of giac? Currently at 1.9.999, which means the next major bump of giac will be rejected. |
comment:11
lgtm |
Reviewer: Dima Pasechnik |
Changed branch from u/mkoeppe/bump_giac_s_giac_min_version_to_1_9 to |
some distro's e.g. Fedora 34, carry giac 1.7, which is too old
Component: build: configure
Author: Matthias Koeppe
Branch/Commit:
d615eb2
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/34857
The text was updated successfully, but these errors were encountered: