Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump giac's GIAC_MIN_VERSION to 1.9 #34857

Closed
dimpase opened this issue Dec 18, 2022 · 15 comments
Closed

bump giac's GIAC_MIN_VERSION to 1.9 #34857

dimpase opened this issue Dec 18, 2022 · 15 comments

Comments

@dimpase
Copy link
Member

dimpase commented Dec 18, 2022

some distro's e.g. Fedora 34, carry giac 1.7, which is too old

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: d615eb2

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34857

@dimpase dimpase added this to the sage-9.8 milestone Dec 18, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

comment:1

too old for what?

@kiwifb
Copy link
Member

kiwifb commented Dec 19, 2022

comment:2

Because #32354 raised the version of giac needed to 1.7.0-27 but didn't change GIAC_MIN_VERSION accordingly. Raising to 1.9 feels appropriate now.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

comment:3

ubuntu-jammy (LTS) only has 1.7.0.39, so I think it's better to just raise to some 1.7 version

@kiwifb
Copy link
Member

kiwifb commented Dec 19, 2022

comment:4

Replying to Matthias Köppe:

ubuntu-jammy (LTS) only has 1.7.0.39, so I think it's better to just raise to some 1.7 version

I am OK to raise it to just 1.7.0-27, I cannot think of any other tickets like #32354.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

comment:5

Unfortunately we don't know how to check the patchlevel. giac --version only reports 1.7.0 or 1.9.0

@kiwifb
Copy link
Member

kiwifb commented Dec 19, 2022

comment:6

Not even the header have the patch level. I do not think upstream provided a way to figure the patch level.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

comment:7

OK, then let's just use 1.9.0. Given that downstream versions of giac are affected by #33848, it's not a big loss that we have to build our own giac on ubuntu-jammy.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

New commits:

d615eb2build/pkgs/giac/spkg-configure.m4: Require giac >= 1.9.0

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

Commit: d615eb2

@kiwifb
Copy link
Member

kiwifb commented Dec 19, 2022

comment:10

Well, I didn't realise the minimum version of giac was so low. I am not sure 1.5 releases would have work well, even before #32354. That's a rather trivial change. Do we want to keep a check on an upper version of giac? Currently at 1.9.999, which means the next major bump of giac will be rejected.

@dimpase
Copy link
Member Author

dimpase commented Dec 19, 2022

comment:11

lgtm

@dimpase
Copy link
Member Author

dimpase commented Dec 19, 2022

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Jan 12, 2023

Changed branch from u/mkoeppe/bump_giac_s_giac_min_version_to_1_9 to d615eb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants