Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some W605 in pyx files in rings #34639

Closed
fchapoton opened this issue Oct 9, 2022 · 7 comments
Closed

fix some W605 in pyx files in rings #34639

fchapoton opened this issue Oct 9, 2022 · 7 comments
Labels
c: commutative algebra p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

namely in polynomials/, number_fields/ and finite_rings/

CC: @tscrim @kwankyu @kliem @slel

Component: commutative algebra

Author: Frédéric Chapoton

Branch/Commit: f948791

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34639
@fchapoton fchapoton added this to the sage-9.8 milestone Oct 9, 2022
@fchapoton
Copy link
Contributor Author

Commit: f948791

@fchapoton
Copy link
Contributor Author

New commits:

f948791fix some W605 in pyx files in rings/

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34639

@fchapoton
Copy link
Contributor Author

comment:2

green bot, so please review. Should be an easy one

@tscrim
Copy link
Collaborator

tscrim commented Oct 10, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 10, 2022

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/chapoton/34639 to f948791

@vbraun vbraun closed this as completed in 3384309 Oct 16, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: commutative algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton