Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep cleanup for the file weyl_group.py #34620

Closed
fchapoton opened this issue Sep 30, 2022 · 8 comments
Closed

pep cleanup for the file weyl_group.py #34620

fchapoton opened this issue Sep 30, 2022 · 8 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: f83a25d

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34620
@fchapoton fchapoton added this to the sage-9.8 milestone Sep 30, 2022
@fchapoton
Copy link
Contributor Author

Commit: f83a25d

@fchapoton
Copy link
Contributor Author

New commits:

f83a25dpep cleanup for Weyl groups

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34620

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

comment:2

on the way you could change """ -> r""" where needed

@fchapoton
Copy link
Contributor Author

comment:3

En principe, les fichiers .py passent maintenant tous par sage --tox -e rst et divers vérificateurs, qui détectent si il manque r""" quelque part. Donc normalement, ça ne manque plus nul part, sauf dans les fichiers .pyx.

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

comment:4

OK.

LGTM.

@dcoudert
Copy link
Contributor

dcoudert commented Oct 1, 2022

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/chapoton/34620 to f83a25d

@vbraun vbraun closed this as completed in 23db2d4 Oct 16, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert