Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use libgap in dual abelian group elements #34618

Closed
fchapoton opened this issue Sep 30, 2022 · 9 comments
Closed

use libgap in dual abelian group elements #34618

fchapoton opened this issue Sep 30, 2022 · 9 comments
Labels
c: group theory p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

instead of the pexpect interface for gap

CC: @tscrim @kwankyu @kliem @slel

Component: group theory

Author: Frédéric Chapoton

Branch/Commit: 9ee09df

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34618
@fchapoton fchapoton added this to the sage-9.8 milestone Sep 30, 2022
@fchapoton
Copy link
Contributor Author

Commit: 79ce7d9

@fchapoton
Copy link
Contributor Author

New commits:

79ce7d9use libgap in elements of dual abelian groups

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34618

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Changed commit from 79ce7d9 to 9ee09df

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9ee09dfremove import

@fchapoton
Copy link
Contributor Author

comment:3

morally green lights, so please review

@tscrim
Copy link
Collaborator

tscrim commented Oct 2, 2022

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 2, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/chapoton/34618 to 9ee09df

@vbraun vbraun closed this as completed in c448d77 Oct 16, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: group theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton