Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8 cleanup in algebras/letterplace pyx files #34585

Closed
fchapoton opened this issue Sep 25, 2022 · 15 comments
Closed

pep8 cleanup in algebras/letterplace pyx files #34585

fchapoton opened this issue Sep 25, 2022 · 15 comments
Labels
c: algebra p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim @kwankyu @kliem @dcoudert

Component: algebra

Author: Frédéric Chapoton

Branch/Commit: 1d6ce21

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34585
@fchapoton fchapoton added this to the sage-9.8 milestone Sep 25, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34585

@fchapoton
Copy link
Contributor Author

Commit: 8540c9a

@fchapoton
Copy link
Contributor Author

New commits:

8540c9apep8 cleanup in algebras/letterplace (pyx files)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 25, 2022

Changed commit from 8540c9a to a4f089d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 25, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a4f089dfix mistakes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 25, 2022

Changed commit from a4f089d to 6dca1c4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 25, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6dca1c4fix back the max

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 27, 2022

comment:4

test failures

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2022

Changed commit from 6dca1c4 to 1d6ce21

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1d6ce21pep8 cleanup in algebras/letterplace (pyx files)

@fchapoton
Copy link
Contributor Author

comment:6

hopefully fixed now

@fchapoton
Copy link
Contributor Author

comment:7

green bot, so please review

@tscrim
Copy link
Collaborator

tscrim commented Oct 2, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 2, 2022

comment:8

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/chapoton/34585 to 1d6ce21

@vbraun vbraun closed this as completed in e77f1a4 Oct 16, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe