Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate unused PermutationGroup_generic.has_element #33831

Closed
mantepse opened this issue May 10, 2022 · 15 comments
Closed

deprecate unused PermutationGroup_generic.has_element #33831

mantepse opened this issue May 10, 2022 · 15 comments
Labels
c: group theory p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@mantepse
Copy link
Contributor

The method PermutationGroup_generic.has_element is unused and G.has_element(g) is the same as g in G. It should therefore be deprecated.

Component: group theory

Author: Martin Rubey

Branch/Commit: 1a13f63

Reviewer: David Ayotte

Issue created by migration from https://trac.sagemath.org/ticket/33831
@mantepse mantepse added this to the sage-9.7 milestone May 10, 2022
@mantepse
Copy link
Contributor Author

Author: Martin Rubey

@mantepse
Copy link
Contributor Author

Branch: u/mantepse/deprecate_unused_permutationgroup_generic_has_element

@mantepse
Copy link
Contributor Author

Commit: eb1a786

@mantepse

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor

comment:5

empty branch, did you forget to commit ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f171687deprecate has_element

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2022

Changed commit from eb1a786 to f171687

@mantepse
Copy link
Contributor Author

comment:7

yes :-)

@jhpalmieri
Copy link
Member

comment:8

Minor point: the preferred style is for warning messages (like deprecations) to not start with a capital and to not end with a period.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1a13f63fix style of warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2022

Changed commit from f171687 to 1a13f63

@mantepse
Copy link
Contributor Author

comment:10

done :-)

@DavidAyotte
Copy link
Member

Reviewer: David Ayotte

@DavidAyotte
Copy link
Member

comment:11

It looks good to me! Thanks!

@vbraun
Copy link
Member

vbraun commented May 24, 2022

Changed branch from u/mantepse/deprecate_unused_permutationgroup_generic_has_element to 1a13f63

@vbraun vbraun closed this as completed in 2bb3b14 May 24, 2022
This was referenced May 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: group theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
5 participants
@vbraun @jhpalmieri @fchapoton @mantepse @DavidAyotte