Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycodestyle formatting in sage_docbuild #33301

Closed
fchapoton opened this issue Feb 6, 2022 · 11 comments
Closed

pycodestyle formatting in sage_docbuild #33301

fchapoton opened this issue Feb 6, 2022 · 11 comments

Comments

@fchapoton
Copy link
Contributor

mainly cosmetic details

also convert some "Returns" to "Return"

Component: doctest framework

Author: Frédéric Chapoton

Branch/Commit: 1040829

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/33301

@fchapoton
Copy link
Contributor Author

New commits:

c3f02f4pycodestyle formatting in sage_docbuild

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33301

@fchapoton
Copy link
Contributor Author

Commit: c3f02f4

@dcoudert
Copy link
Contributor

dcoudert commented Feb 6, 2022

comment:2

in src/sage_docbuild/__init__.py (aren't we on the way to remove __init__.py files ?) there are several places where you have not separated the first docstring and the rest of the paragraph, e.g.

 def get_builder(name):
     """
-    Returns an appropriate *Builder object for the document ``name``.
+    Return an appropriate *Builder object for the document ``name``.
     DocBuilder and its subclasses do all the real work in building the
     documentation.
     def get_all_documents(self):
         """
-        Returns a list of all of the documents. A document is a directory within one of
+        Return a list of all of the documents. A document is a directory within one of
         the language subdirectories of SAGE_DOC_SRC specified by the global LANGUAGES
         variable.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2022

Changed commit from c3f02f4 to 1040829

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1040829more details in docbuild __init__

@fchapoton
Copy link
Contributor Author

comment:4

Voilà qui est fait.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 6, 2022

comment:5

Replying to @dcoudert:

aren't we on the way to remove __init__.py files ?

Not all of them, only for namespace packages - https://doc.sagemath.org/html/en/developer/packaging_sage_library.html#ordinary-packages-vs-implicit-namespace-packages

@dcoudert
Copy link
Contributor

dcoudert commented Feb 6, 2022

comment:6

Unless I'm mistaken, the error reported by the patchbot has nothing to do with the changes done in this ticket.

LGTM.

@dcoudert
Copy link
Contributor

dcoudert commented Feb 6, 2022

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Changed branch from u/chapoton/33301 to 1040829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants