Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable code in sage/graphs/base/c_graph.pyx #33174

Closed
orlitzky opened this issue Jan 14, 2022 · 7 comments
Closed

Unreachable code in sage/graphs/base/c_graph.pyx #33174

orlitzky opened this issue Jan 14, 2022 · 7 comments

Comments

@orlitzky
Copy link
Contributor

The body of this function is unreachable,

cdef bint _has_labeled_edge_unsafe(self, int u_int, int v_int, object l) except -1:
    """                                                                     
    Return whether ``self`` has an arc specified by indices of the vertices 
    and an arc label.                                                       
    """
    raise NotImplementedError
    cdef int l_int
    if l is None:
        l_int = 0
    else:
        l_int = self.new_edge_label(l)
    return self.cg().has_arc_unsafe(u_int, v_int, l_int)

Is it just an oversight?

CC: @kliem

Component: graph theory

Author: David Coudert

Branch/Commit: 7852073

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33174

@orlitzky orlitzky added this to the sage-9.6 milestone Jan 14, 2022
@dcoudert
Copy link
Contributor

Commit: 7852073

@dcoudert
Copy link
Contributor

Branch: public/graphs/33174

@dcoudert
Copy link
Contributor

Author: David Coudert

@dcoudert
Copy link
Contributor

comment:1

I agree we just forgot to remove this code.


New commits:

7852073trac #33174: remove unreachable code

@orlitzky
Copy link
Contributor Author

comment:2

Ok, thanks!

@orlitzky
Copy link
Contributor Author

Reviewer: Michael Orlitzky

@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Changed branch from public/graphs/33174 to 7852073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants