-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some details in shuffle and multizeta #33102
Comments
Branch: u/chapoton/33102 |
Commit: |
New commits:
|
comment:3
a minor detail, isn't it better to use itertools.chain here - w1_parent(list(self._w1) + list(self._w2), check=self._check)
+ w1_parent(list(itertools.chain(self._w1, self._w2)), check=self._check) |
comment:4
Salut, bonne année. Merci pour le commentaire. Je ne suis pas très convaincu qu'on gagne quelque chose à utiliser itertools ici. C'est en dehors de la boucle principale. |
comment:5
Bonne année. Effectivement, le gain n'est pas clair du tout donc autant rester simple. LGTM. |
Reviewer: David Coudert |
comment:6
Bonne année. En option on pourrait changer au passage: - sage: S.list() #indirect test
+ sage: S.list() # indirect doctest |
Changed branch from u/chapoton/33102 to |
trying to make the shuffle simpler and the product of MZV slightly faster
Component: combinatorics
Author: Frédéric Chapoton
Branch/Commit:
7229a19
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/33102
The text was updated successfully, but these errors were encountered: