Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some details in shuffle and multizeta #33102

Closed
fchapoton opened this issue Jan 1, 2022 · 9 comments
Closed

some details in shuffle and multizeta #33102

fchapoton opened this issue Jan 1, 2022 · 9 comments

Comments

@fchapoton
Copy link
Contributor

trying to make the shuffle simpler and the product of MZV slightly faster

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 7229a19

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/33102

@fchapoton fchapoton added this to the sage-9.5 milestone Jan 1, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33102

@fchapoton
Copy link
Contributor Author

Commit: 7229a19

@fchapoton
Copy link
Contributor Author

New commits:

7229a19some details about shuffle of words and multizetas

@dcoudert
Copy link
Contributor

dcoudert commented Jan 1, 2022

comment:3

a minor detail, isn't it better to use itertools.chain here

-            w1_parent(list(self._w1) + list(self._w2), check=self._check)
+            w1_parent(list(itertools.chain(self._w1, self._w2)), check=self._check)

@fchapoton
Copy link
Contributor Author

comment:4

Salut, bonne année. Merci pour le commentaire. Je ne suis pas très convaincu qu'on gagne quelque chose à utiliser itertools ici. C'est en dehors de la boucle principale.

@dcoudert
Copy link
Contributor

dcoudert commented Jan 1, 2022

comment:5

Bonne année. Effectivement, le gain n'est pas clair du tout donc autant rester simple.

LGTM.

@dcoudert
Copy link
Contributor

dcoudert commented Jan 1, 2022

Reviewer: David Coudert

@slel
Copy link
Member

slel commented Jan 2, 2022

comment:6

Bonne année. En option on pourrait changer au passage:

-            sage: S.list() #indirect test
+            sage: S.list()  # indirect doctest

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/chapoton/33102 to 7229a19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants