Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx to 4.3 #32968

Closed
tobihan opened this issue Dec 4, 2021 · 14 comments
Closed

Update sphinx to 4.3 #32968

tobihan opened this issue Dec 4, 2021 · 14 comments

Comments

@tobihan
Copy link

tobihan commented Dec 4, 2021

In Debian with sphinx 4.3.1 I am getting these errors when building the documentation:

Extension error (sage.docs.conf):
Handler <function find_sage_dangling_links at 0x7fe31e14bf70> for event 'missing-reference' threw an exception (exception: No such config value: intersphinx_disabled_reftypes)

intersphinx_disabled_reftypes was introduced in sphinx 4.3.0 so I think we need to change something for compatibility.

CC: @kiwifb @antonio-rojas

Component: packages: standard

Author: François Bissey

Branch/Commit: 170f1cf

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32968

@tobihan tobihan added this to the sage-9.6 milestone Dec 4, 2021
@tobihan
Copy link
Author

tobihan commented Dec 7, 2021

Attachment: u1-version-sphinx-4.3.patch.gz

@tobihan
Copy link
Author

tobihan commented Dec 7, 2021

comment:1

The problem is fixed with the attached patch.

@kiwifb
Copy link
Member

kiwifb commented Dec 12, 2021

comment:3

Patch works for me in sage-on-gentoo with sphinx 4.3.1. I think we should make it into a proper branch.

Do you have something different or a previous ticket @antonio-rojas?

@antonio-rojas
Copy link
Contributor

comment:4

I generally only build docs for stable releases, so I haven't tested sphinx 4.3 yet.

@kiwifb
Copy link
Member

kiwifb commented Dec 12, 2021

Branch: u/fbissey/sphinx-4.3.1

@kiwifb
Copy link
Member

kiwifb commented Dec 12, 2021

Author: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Dec 12, 2021

Commit: fc84f82

@kiwifb
Copy link
Member

kiwifb commented Dec 12, 2021

comment:5

OK, this is ready for inspection.


New commits:

e2adfb1Update sphinx to 4.3.1
efb00a8update sphinx dependency list and special installation instructions
25cba02add gentoo distros file
fc84f82Add required new option for sphinx 4.3+ as per Tobias Hansen's original patch

@kiwifb kiwifb modified the milestones: sage-9.6, sage-9.5 Dec 12, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2021

Reviewer: Matthias Koeppe

@kiwifb
Copy link
Member

kiwifb commented Dec 19, 2021

comment:8

Thanks :)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 24, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

170f1cfMerge branch 'develop' into sphinx-4.3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 24, 2021

Changed commit from fc84f82 to 170f1cf

@kiwifb
Copy link
Member

kiwifb commented Dec 24, 2021

comment:10

Trivially rebased on new beta. Back to positive review.

@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/fbissey/sphinx-4.3.1 to 170f1cf

@vbraun vbraun closed this as completed in 2d74bd4 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants