Features for latex packages #32926

mkoeppe · 2021-11-24T01:36:22Z

Add Features LaTeXPackage to detect presence of latex packages.

Depends on #32174

CC: @seblabbe @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch: e22c173

Reviewer: Kwankyu Lee, Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/32926

The text was updated successfully, but these errors were encountered:

mkoeppe · 2021-11-24T02:03:56Z

Branch: u/mkoeppe/features_for_latex_packages

mkoeppe · 2021-11-24T02:07:11Z

Dependencies: #32174

mkoeppe · 2021-11-24T02:07:11Z

Last 10 new commits:

`12f7c98`	`src/sage/features/polymake.py: Add all_features`
`c9312db`	`src/sage/features: Add more all_features functions`
`230d135`	`src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Fix doctest markup`
`7a8f48c`	`src/sage/features/sagemath.py (sage_features): Unused now, removed`
`e7f538d`	`sage.features.bliss: Change name of BlissLibrary feature to libbliss, remove it from all_features`
`12a2507`	`src/sage/features/interfaces.py: Fix indentation in docstring`
`0dd76b6`	`Merge tag '9.5.beta7' into t/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used`
`07b2512`	`src/sage/misc/latex.py: Conditionalize some doctests on latex_package_tkz_graph`
`2dd9ad3`	`Merge #32174`
`42d35b0`	`src/sage/features/latex.py (TeXFile, LaTeXPackage, 'latex_package_tkz_graph'): New`

mkoeppe · 2021-11-24T02:07:11Z

Commit: 42d35b0

seblabbe · 2021-11-25T11:08:50Z

comment:4

When testing the feature, I get:

NameError: name 'FeatureNotPresentError' is not defined

an import is missing.

sagetrac-git · 2021-11-25T18:02:21Z

Branch pushed to git repo; I updated commit sha1. New commits:

`da1e922`	`src/sage/features/latex.py: Add missing import`

sagetrac-git · 2021-11-25T18:02:21Z

Changed commit from 42d35b0 to da1e922

kwankyu · 2021-11-30T12:50:06Z

comment:8

diff --git a/src/sage/features/latex.py b/src/sage/features/latex.py
index 7b95796be4..7bd8d72164 100644
--- a/src/sage/features/latex.py
+++ b/src/sage/features/latex.py
@@ -147,7 +147,7 @@ class TeXFile(StaticFile):
         sage: from sage.features.latex import TeXFile
         sage: TeXFile('x', 'x.tex').is_present()  # optional: pdflatex
         FeatureTestResult('x', True)
-        sage: TeXFile('nonexisting', 'fajfhjdksf-nonexisting-file.tex').is_present()  # optional: pdflatex
+        sage: TeXFile('nonexisting', 'xxxxxx-nonexisting-file.tex').is_present()  # optional - pdflatex
         FeatureTestResult('nonexisting', False)
     """
     def __init__(self, name, filename, **kwds):
@@ -161,7 +161,7 @@ class TeXFile(StaticFile):
 
             sage: from sage.features.latex import TeXFile
             sage: feature = TeXFile('latex_class_article', 'article.cls')
-            sage: feature.absolute_path()  # optional: pdflatex
+            sage: feature.absolute_path()  # optional - pdflatex
             '.../latex/base/article.cls'
         """
         from subprocess import run, CalledProcessError, PIPE
@@ -183,7 +183,7 @@ class LaTeXPackage(TeXFile):
     EXAMPLES::
 
         sage: from sage.features.latex import LaTeXPackage
-        sage: LaTeXPackage('graphics').is_present()  # optional: pdflatex
+        sage: LaTeXPackage('graphics').is_present()  # optional - pdflatex
         FeatureTestResult('latex_package_graphics', True)
     """
     @staticmethod

Otherwise, looks good to me.

kwankyu · 2021-11-30T12:50:18Z

Reviewer: Kwankyu Lee

mkoeppe · 2021-11-30T17:01:25Z

comment:10

I agree with these changes, please push them to the ticket

kwankyu · 2021-12-01T00:21:00Z

Changed branch from u/mkoeppe/features_for_latex_packages to public/32926

kwankyu · 2021-12-01T00:21:00Z

Changed commit from da1e922 to none

sagetrac-git · 2021-12-01T00:21:13Z

Commit: ddac7bc

sagetrac-git · 2021-12-01T00:21:13Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`230d135`	`src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Fix doctest markup`
`7a8f48c`	`src/sage/features/sagemath.py (sage_features): Unused now, removed`
`e7f538d`	`sage.features.bliss: Change name of BlissLibrary feature to libbliss, remove it from all_features`
`12a2507`	`src/sage/features/interfaces.py: Fix indentation in docstring`
`0dd76b6`	`Merge tag '9.5.beta7' into t/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used`
`07b2512`	`src/sage/misc/latex.py: Conditionalize some doctests on latex_package_tkz_graph`
`2dd9ad3`	`Merge #32174`
`42d35b0`	`src/sage/features/latex.py (TeXFile, LaTeXPackage, 'latex_package_tkz_graph'): New`
`da1e922`	`src/sage/features/latex.py: Add missing import`
`ddac7bc`	`Small edits`

kwankyu · 2021-12-01T00:22:40Z

comment:13

Okay. Done.

kwankyu · 2021-12-01T00:24:28Z

comment:15

Let's wait for the patchbot run once more.

sagetrac-git · 2021-12-01T18:17:47Z

Changed commit from 60bdd71 to 140575c

sagetrac-git · 2021-12-01T18:17:47Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`cb13437`	`32174: fix the --show-skipped doctest report`
`391dca1`	`sage.misc.latex.png: Mark doctest # optional - imagemagick`
`6f311b3`	`src/sage/doctest/external.py: Revert latex features to 'external'`
`3bfe1a1`	`32174: adapting the doctest listing external softwares`
`e41cf29`	`src/sage/features/latex.py (TeXFile, LaTeXPackage, 'latex_package_tkz_graph'): New`
`8d875d5`	`src/sage/features/latex.py: Add missing import`
`140575c`	`Small edits`

mkoeppe · 2021-12-01T18:17:59Z

comment:23

rebased on top of updated #32174

seblabbe · 2021-12-01T21:15:17Z

comment:24

Replying to @seblabbe:

Also notice:

To install imagemagick using the debian package manager, you can try to run:
    !sudo apt-get update 
    !sudo apt-get install  texlive-latex-extra texlive-xetex latexmk dvipng default-jdk ffmpeg libavdevice-dev

See #32956 to deal with that.

kwankyu · 2021-12-03T05:35:04Z

Changed reviewer from Kwankyu Lee to Kwankyu Lee; Sébastien Labbé

kwankyu · 2021-12-03T05:35:04Z

comment:25

No more thing to do here. Right?

slel · 2021-12-03T05:53:12Z

comment:26

Maybe a short ticket description?

E.g. is there a meta-ticket or documentation page
or release tour item about "features"?

Other than that, this ticket depends on #32174
which still needs review.

kwankyu · 2021-12-03T06:48:48Z

comment:27

Okay then.

kwankyu · 2021-12-03T08:06:19Z

comment:30

As the dependency #32174 just got positive review.

vbraun · 2021-12-12T15:59:45Z

comment:31

sage -t --long --warn-long 41.2 --random-seed=90818346224792411697676027482246961463 src/sage/doctest/external.py
**********************************************************************
File "src/sage/doctest/external.py", line 379, in sage.doctest.external.AvailableSoftware
Failed example:
    external_software
Expected:
    ['cplex',
     'gurobi',
     'internet',
     'latex',
     'lualatex',
     'macaulay2',
     'magma',
     'maple',
     'mathematica',
     'matlab',
     'octave',
     'pdflatex',
     'scilab',
     'xelatex']
Got:
    ['cplex',
     'gurobi',
     'internet',
     'latex',
     'latex_package_tkz_graph',
     'lualatex',
     'macaulay2',
     'magma',
     'maple',
     'mathematica',
     'matlab',
     'octave',
     'pdflatex',
     'scilab',
     'xelatex']
**********************************************************************
1 item had failures:
   1 of   3 in sage.doctest.external.AvailableSoftware
    [40 tests, 1 failure, 0.02 s]

sagetrac-git · 2021-12-12T17:39:57Z

Changed commit from 140575c to e22c173

sagetrac-git · 2021-12-12T17:39:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`29a0750`	`Merge tag '9.5.beta8' into t/32926/public/32926`
`e22c173`	`src/sage/doctest/external.py: Update doctest output`

vbraun · 2021-12-19T11:46:46Z

Changed branch from public/32926 to e22c173

mkoeppe · 2022-01-30T18:23:27Z

Changed commit from e22c173 to none

mkoeppe · 2022-01-30T18:23:27Z

Changed reviewer from Kwankyu Lee; Sébastien Labbé to Kwankyu Lee, Sébastien Labbé

mkoeppe added this to the sage-9.5 milestone Nov 24, 2021

mkoeppe added t: refactoring labels Nov 24, 2021

mkoeppe added the s: needs review label Nov 24, 2021

seblabbe added s: needs work and removed s: needs review labels Nov 25, 2021

mkoeppe added s: needs review and removed s: needs work labels Nov 25, 2021

kwankyu added s: positive review and removed s: needs review labels Dec 1, 2021

kwankyu removed the s: needs work label Dec 1, 2021

kwankyu added s: positive review and removed s: needs review labels Dec 3, 2021

kwankyu added s: needs work and removed s: positive review labels Dec 3, 2021

This comment has been minimized.

Sign in to view

kwankyu added s: needs review and removed s: needs work labels Dec 3, 2021

kwankyu added s: positive review and removed s: needs review labels Dec 3, 2021

vbraun added s: needs work and removed s: positive review labels Dec 12, 2021

mkoeppe added s: positive review and removed s: needs work labels Dec 12, 2021

vbraun removed the s: positive review label Dec 19, 2021

vbraun closed this as completed in 6080161 Dec 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Features for latex packages #32926

Features for latex packages #32926

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

seblabbe commented Nov 25, 2021

sagetrac-git mannequin commented Nov 25, 2021

sagetrac-git mannequin commented Nov 25, 2021

kwankyu commented Nov 30, 2021

kwankyu commented Nov 30, 2021

mkoeppe commented Nov 30, 2021

kwankyu commented Dec 1, 2021

kwankyu commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

kwankyu commented Dec 1, 2021

kwankyu commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

mkoeppe commented Dec 1, 2021

seblabbe commented Dec 1, 2021

kwankyu commented Dec 3, 2021

kwankyu commented Dec 3, 2021

slel commented Dec 3, 2021

kwankyu commented Dec 3, 2021

This comment has been minimized.

kwankyu commented Dec 3, 2021

vbraun commented Dec 12, 2021

sagetrac-git mannequin commented Dec 12, 2021

sagetrac-git mannequin commented Dec 12, 2021

vbraun commented Dec 19, 2021

mkoeppe commented Jan 30, 2022

mkoeppe commented Jan 30, 2022

Features for latex packages #32926

Features for latex packages #32926

Comments

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

mkoeppe commented Nov 24, 2021

seblabbe commented Nov 25, 2021

sagetrac-git mannequin commented Nov 25, 2021

sagetrac-git mannequin commented Nov 25, 2021

kwankyu commented Nov 30, 2021

kwankyu commented Nov 30, 2021

mkoeppe commented Nov 30, 2021

kwankyu commented Dec 1, 2021

kwankyu commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

kwankyu commented Dec 1, 2021

kwankyu commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

sagetrac-git mannequin commented Dec 1, 2021

mkoeppe commented Dec 1, 2021

seblabbe commented Dec 1, 2021

kwankyu commented Dec 3, 2021

kwankyu commented Dec 3, 2021

slel commented Dec 3, 2021

kwankyu commented Dec 3, 2021

This comment has been minimized.

kwankyu commented Dec 3, 2021

vbraun commented Dec 12, 2021

sagetrac-git mannequin commented Dec 12, 2021

sagetrac-git mannequin commented Dec 12, 2021

vbraun commented Dec 19, 2021

mkoeppe commented Jan 30, 2022

mkoeppe commented Jan 30, 2022