Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pictures to disk.py #32912

Closed
sagetrac-jhonrubia6 mannequin opened this issue Nov 20, 2021 · 14 comments
Closed

Add pictures to disk.py #32912

sagetrac-jhonrubia6 mannequin opened this issue Nov 20, 2021 · 14 comments

Comments

@sagetrac-jhonrubia6
Copy link
Mannequin

sagetrac-jhonrubia6 mannequin commented Nov 20, 2021

Add illustrations to the examples presented on the docstring

Component: documentation

Keywords: disk, plot

Author: Javier Honrubia González

Branch/Commit: 57a4352

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/32912

@sagetrac-jhonrubia6 sagetrac-jhonrubia6 mannequin added this to the sage-9.5 milestone Nov 20, 2021
@sagetrac-jhonrubia6

This comment has been minimized.

@sagetrac-jhonrubia6
Copy link
Mannequin Author

sagetrac-jhonrubia6 mannequin commented Nov 20, 2021

Changed keywords from none to disk, plot

@sagetrac-jhonrubia6
Copy link
Mannequin Author

sagetrac-jhonrubia6 mannequin commented Nov 20, 2021

Author: Javier Honrubia González

@sagetrac-jhonrubia6 sagetrac-jhonrubia6 mannequin self-assigned this Nov 20, 2021
@sagetrac-jhonrubia6
Copy link
Mannequin Author

sagetrac-jhonrubia6 mannequin commented Nov 25, 2021

Branch: u/jhonrubia6/add_pictures_to_plot_py

@sagetrac-jhonrubia6
Copy link
Mannequin Author

sagetrac-jhonrubia6 mannequin commented Nov 25, 2021

Commit: 66117b7

@sagetrac-jhonrubia6
Copy link
Mannequin Author

sagetrac-jhonrubia6 mannequin commented Nov 25, 2021

New commits:

66117b7Added illustrations for the exisiting examples on disks

@sagetrac-jhonrubia6 sagetrac-jhonrubia6 mannequin changed the title Add pictures to plot.py Add pictures to disk.py Nov 25, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5ed4040formatting according to tox tool.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2021

Changed commit from 66117b7 to 5ed4040

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 10, 2021

comment:5
diff --git a/src/sage/plot/disk.py b/src/sage/plot/disk.py
index 1e135a85ff..14588fd8ef 100644
--- a/src/sage/plot/disk.py
+++ b/src/sage/plot/disk.py
@@ -259,7 +259,7 @@ def disk(point, radius, angle, **options):
         sage: br = disk((0.0,0.0), 1, (3*pi/2, 2*pi), color='black')
         sage: P  = tl+tr+bl+br
         sage: P.show(xmin=-2,xmax=2,ymin=-2,ymax=2)
-make
+
     .. PLOT::
 
         from sage.plot.disk import Disk

Otherwise, looks good.

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 10, 2021

Reviewer: Kwankyu Lee

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

57a4352cleaned

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2021

Changed commit from 5ed4040 to 57a4352

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 23, 2021

comment:8

LGTM.

@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Changed branch from u/jhonrubia6/add_pictures_to_plot_py to 57a4352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants