Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search of doc pages is broken #32854

Closed
haraldschilly opened this issue Nov 11, 2021 · 7 comments
Closed

search of doc pages is broken #32854

haraldschilly opened this issue Nov 11, 2021 · 7 comments

Comments

@haraldschilly
Copy link
Member

when searching on https://doc.sagemath.org/html/en/reference/search.html?q=plot an error about a jQuery incompatibility causes it to break.

Is this already reported? I just heard about this.

Component: documentation

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32854

@jhpalmieri
Copy link
Member

comment:1

Duplicate of #29576?

@haraldschilly
Copy link
Member Author

comment:2

Thank you, well, I don't think this is a duplicate, because I know that for the previous version the search worked (while producing those square bracket object output strings).

This time around, Thebe is actually breaking the code. So, IMHO, common solution to both tickets is to get rid of that library and make a new ticket to figure out how to add it back "safely", or to at least check what its current status is.

@haraldschilly
Copy link
Member Author

comment:3

here is the stacktrace I see

@fchapoton
Copy link
Contributor

comment:4

bump to 9.6

@fchapoton fchapoton modified the milestones: sage-9.5, sage-9.6 Jan 29, 2022
@haraldschilly
Copy link
Member Author

comment:5

For 9.5, the error is slightly different:

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 10, 2022

comment:6

In #33309, we turned off Thebe, fixing search box.

@kwankyu kwankyu removed this from the sage-9.6 milestone Feb 10, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2022

Reviewer: Matthias Koeppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants